* [PATCH net] s390/qeth: support net namespaces for L3 devices
@ 2020-03-27 11:00 Julian Wiedmann
2020-03-27 22:39 ` David Miller
2020-03-30 5:02 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Julian Wiedmann @ 2020-03-27 11:00 UTC (permalink / raw)
To: David Miller
Cc: netdev, linux-s390, Heiko Carstens, Ursula Braun, Julian Wiedmann
Enable the L3 driver's IPv4 address notifier to watch for events on qeth
devices that have been moved into a net namespace. We need to program
those IPs into the HW just as usual, otherwise inbound traffic won't
flow.
Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
---
drivers/s390/net/qeth_l3_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/s390/net/qeth_l3_main.c b/drivers/s390/net/qeth_l3_main.c
index 82f800d1d7b3..46c212118022 100644
--- a/drivers/s390/net/qeth_l3_main.c
+++ b/drivers/s390/net/qeth_l3_main.c
@@ -2204,9 +2204,6 @@ static int qeth_l3_ip_event(struct notifier_block *this,
struct qeth_ipaddr addr;
struct qeth_card *card;
- if (dev_net(dev) != &init_net)
- return NOTIFY_DONE;
-
card = qeth_l3_get_card_from_dev(dev);
if (!card)
return NOTIFY_DONE;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] s390/qeth: support net namespaces for L3 devices
2020-03-27 11:00 [PATCH net] s390/qeth: support net namespaces for L3 devices Julian Wiedmann
@ 2020-03-27 22:39 ` David Miller
2020-03-28 10:34 ` Julian Wiedmann
2020-03-30 5:02 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2020-03-27 22:39 UTC (permalink / raw)
To: jwi; +Cc: netdev, linux-s390, heiko.carstens, ubraun
From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Fri, 27 Mar 2020 12:00:42 +0100
> Enable the L3 driver's IPv4 address notifier to watch for events on qeth
> devices that have been moved into a net namespace. We need to program
> those IPs into the HW just as usual, otherwise inbound traffic won't
> flow.
>
> Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
This looks more like a feature, openning the L3 driver into multiple
namespaces, rather than a critical fix.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] s390/qeth: support net namespaces for L3 devices
2020-03-27 22:39 ` David Miller
@ 2020-03-28 10:34 ` Julian Wiedmann
0 siblings, 0 replies; 4+ messages in thread
From: Julian Wiedmann @ 2020-03-28 10:34 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-s390, heiko.carstens, ubraun
On 27.03.20 23:39, David Miller wrote:
> From: Julian Wiedmann <jwi@linux.ibm.com>
> Date: Fri, 27 Mar 2020 12:00:42 +0100
>
>> Enable the L3 driver's IPv4 address notifier to watch for events on qeth
>> devices that have been moved into a net namespace. We need to program
>> those IPs into the HW just as usual, otherwise inbound traffic won't
>> flow.
>>
>> Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
>> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
>
> This looks more like a feature, openning the L3 driver into multiple
> namespaces, rather than a critical fix.
>
Definitely not 'critical', agreed. It's rather silly though that things
currently work just fine for IPv6, but not for IPv4.
Mind queueing this up for net-next then instead? Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] s390/qeth: support net namespaces for L3 devices
2020-03-27 11:00 [PATCH net] s390/qeth: support net namespaces for L3 devices Julian Wiedmann
2020-03-27 22:39 ` David Miller
@ 2020-03-30 5:02 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-03-30 5:02 UTC (permalink / raw)
To: jwi; +Cc: netdev, linux-s390, heiko.carstens, ubraun
From: Julian Wiedmann <jwi@linux.ibm.com>
Date: Fri, 27 Mar 2020 12:00:42 +0100
> Enable the L3 driver's IPv4 address notifier to watch for events on qeth
> devices that have been moved into a net namespace. We need to program
> those IPs into the HW just as usual, otherwise inbound traffic won't
> flow.
>
> Fixes: 6133fb1aa137 ("[NETNS]: Disable inetaddr notifiers in namespaces other than initial.")
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-30 5:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-27 11:00 [PATCH net] s390/qeth: support net namespaces for L3 devices Julian Wiedmann
2020-03-27 22:39 ` David Miller
2020-03-28 10:34 ` Julian Wiedmann
2020-03-30 5:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).