* [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write
@ 2020-03-30 23:27 Gustavo A. R. Silva
2020-03-30 23:38 ` Jakub Kicinski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2020-03-30 23:27 UTC (permalink / raw)
To: Jakub Kicinski, David S. Miller, Jacob Keller, Jiri Pirko
Cc: netdev, linux-kernel, Gustavo A. R. Silva
In case memory resources for dummy_data were allocated, release them
before return.
Addresses-Coverity-ID: 1491997 ("Resource leak")
Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/net/netdevsim/dev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c
index 2b727a7001f6..9897e9a0e26f 100644
--- a/drivers/net/netdevsim/dev.c
+++ b/drivers/net/netdevsim/dev.c
@@ -75,6 +75,7 @@ static ssize_t nsim_dev_take_snapshot_write(struct file *file,
err = devlink_region_snapshot_id_get(devlink, &id);
if (err) {
pr_err("Failed to get snapshot id\n");
+ kfree(dummy_data);
return err;
}
err = devlink_region_snapshot_create(nsim_dev->dummy_region,
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write
2020-03-30 23:27 [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write Gustavo A. R. Silva
@ 2020-03-30 23:38 ` Jakub Kicinski
2020-03-31 3:14 ` David Miller
2020-03-31 16:59 ` Keller, Jacob E
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-03-30 23:38 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: David S. Miller, Jacob Keller, Jiri Pirko, netdev, linux-kernel
On Mon, 30 Mar 2020 18:27:02 -0500 Gustavo A. R. Silva wrote:
> In case memory resources for dummy_data were allocated, release them
> before return.
>
> Addresses-Coverity-ID: 1491997 ("Resource leak")
> Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write
2020-03-30 23:27 [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write Gustavo A. R. Silva
2020-03-30 23:38 ` Jakub Kicinski
@ 2020-03-31 3:14 ` David Miller
2020-03-31 16:59 ` Keller, Jacob E
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-03-31 3:14 UTC (permalink / raw)
To: gustavo; +Cc: kuba, jacob.e.keller, jiri, netdev, linux-kernel
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 30 Mar 2020 18:27:02 -0500
> In case memory resources for dummy_data were allocated, release them
> before return.
>
> Addresses-Coverity-ID: 1491997 ("Resource leak")
> Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have been used")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write
2020-03-30 23:27 [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write Gustavo A. R. Silva
2020-03-30 23:38 ` Jakub Kicinski
2020-03-31 3:14 ` David Miller
@ 2020-03-31 16:59 ` Keller, Jacob E
2 siblings, 0 replies; 4+ messages in thread
From: Keller, Jacob E @ 2020-03-31 16:59 UTC (permalink / raw)
To: Gustavo A. R. Silva, Jakub Kicinski, David S. Miller, Jiri Pirko
Cc: netdev, linux-kernel
> -----Original Message-----
> From: Gustavo A. R. Silva <gustavo@embeddedor.com>
> Sent: Monday, March 30, 2020 4:27 PM
> To: Jakub Kicinski <kuba@kernel.org>; David S. Miller <davem@davemloft.net>;
> Keller, Jacob E <jacob.e.keller@intel.com>; Jiri Pirko <jiri@mellanox.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Gustavo A. R. Silva
> <gustavo@embeddedor.com>
> Subject: [PATCH net-next] netdevsim: dev: Fix memory leak in
> nsim_dev_take_snapshot_write
>
> In case memory resources for dummy_data were allocated, release them
> before return.
>
> Addresses-Coverity-ID: 1491997 ("Resource leak")
> Fixes: 7ef19d3b1d5e ("devlink: report error once U32_MAX snapshot ids have
> been used")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
Ahh! Thanks!
Belated Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-03-31 16:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-30 23:27 [PATCH net-next] netdevsim: dev: Fix memory leak in nsim_dev_take_snapshot_write Gustavo A. R. Silva
2020-03-30 23:38 ` Jakub Kicinski
2020-03-31 3:14 ` David Miller
2020-03-31 16:59 ` Keller, Jacob E
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).