netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: dsa: ksz: Select KSZ protocol tag
@ 2020-03-31  9:36 Codrin Ciubotariu
  2020-03-31 13:01 ` Andrew Lunn
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Codrin Ciubotariu @ 2020-03-31  9:36 UTC (permalink / raw)
  To: UNGLinuxDriver, netdev, linux-kernel
  Cc: woojung.huh, andrew, vivien.didelot, f.fainelli, davem,
	Codrin Ciubotariu, Cristian Birsan

KSZ protocol tag is needed by the KSZ DSA drivers.

Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---

Patch was tested on a 9477-like switch, but the 8795 variant seems to be
in the same situation.
I am not very sure about the Fixes tag, but it seems to be the one since
it removes the dependency between old NET_DSA_TAG_KSZ9477 and
NET_DSA_TAG_KSZ.

 drivers/net/dsa/microchip/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/microchip/Kconfig b/drivers/net/dsa/microchip/Kconfig
index 1d7870c6df3c..4ec6a47b7f72 100644
--- a/drivers/net/dsa/microchip/Kconfig
+++ b/drivers/net/dsa/microchip/Kconfig
@@ -1,5 +1,6 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config NET_DSA_MICROCHIP_KSZ_COMMON
+	select NET_DSA_TAG_KSZ
 	tristate
 
 menuconfig NET_DSA_MICROCHIP_KSZ9477
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: dsa: ksz: Select KSZ protocol tag
  2020-03-31  9:36 [PATCH] net: dsa: ksz: Select KSZ protocol tag Codrin Ciubotariu
@ 2020-03-31 13:01 ` Andrew Lunn
  2020-03-31 15:57 ` Florian Fainelli
  2020-03-31 17:04 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2020-03-31 13:01 UTC (permalink / raw)
  To: Codrin Ciubotariu
  Cc: UNGLinuxDriver, netdev, linux-kernel, woojung.huh,
	vivien.didelot, f.fainelli, davem, Cristian Birsan

On Tue, Mar 31, 2020 at 12:36:51PM +0300, Codrin Ciubotariu wrote:
> KSZ protocol tag is needed by the KSZ DSA drivers.
> 
> Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
> Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: dsa: ksz: Select KSZ protocol tag
  2020-03-31  9:36 [PATCH] net: dsa: ksz: Select KSZ protocol tag Codrin Ciubotariu
  2020-03-31 13:01 ` Andrew Lunn
@ 2020-03-31 15:57 ` Florian Fainelli
  2020-03-31 17:04 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2020-03-31 15:57 UTC (permalink / raw)
  To: Codrin Ciubotariu, UNGLinuxDriver, netdev, linux-kernel
  Cc: woojung.huh, andrew, vivien.didelot, davem, Cristian Birsan



On 3/31/2020 2:36 AM, Codrin Ciubotariu wrote:
> KSZ protocol tag is needed by the KSZ DSA drivers.
> 
> Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
> Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] net: dsa: ksz: Select KSZ protocol tag
  2020-03-31  9:36 [PATCH] net: dsa: ksz: Select KSZ protocol tag Codrin Ciubotariu
  2020-03-31 13:01 ` Andrew Lunn
  2020-03-31 15:57 ` Florian Fainelli
@ 2020-03-31 17:04 ` David Miller
  2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-03-31 17:04 UTC (permalink / raw)
  To: codrin.ciubotariu
  Cc: UNGLinuxDriver, netdev, linux-kernel, woojung.huh, andrew,
	vivien.didelot, f.fainelli, cristian.birsan

From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Date: Tue, 31 Mar 2020 12:36:51 +0300

> KSZ protocol tag is needed by the KSZ DSA drivers.
> 
> Fixes: 0b9f9dfbfab4 ("dsa: Allow tag drivers to be built as modules")
> Tested-by: Cristian Birsan <cristian.birsan@microchip.com>
> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-03-31 17:05 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-31  9:36 [PATCH] net: dsa: ksz: Select KSZ protocol tag Codrin Ciubotariu
2020-03-31 13:01 ` Andrew Lunn
2020-03-31 15:57 ` Florian Fainelli
2020-03-31 17:04 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).