archive mirror
 help / color / mirror / Atom feed
From: David Miller <>
Subject: Re: [PATCH v2] slcan: Don't transmit uninitialized stack data in padding
Date: Wed, 01 Apr 2020 11:23:18 -0700 (PDT)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Richard Palethorpe <>
Date: Wed,  1 Apr 2020 12:06:39 +0200

> struct can_frame contains some padding which is not explicitly zeroed in
> slc_bump. This uninitialized data will then be transmitted if the stack
> initialization hardening feature is not enabled (CONFIG_INIT_STACK_ALL).
> This commit just zeroes the whole struct including the padding.
> Signed-off-by: Richard Palethorpe <>
> Fixes: a1044e36e457 ("can: add slcan driver for serial/USB-serial CAN adapters")
> Reviewed-by: Kees Cook <>

Applied and queued up for -stable, thanks.

  parent reply	other threads:[~2020-04-01 18:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-01 10:06 [PATCH v2] slcan: Don't transmit uninitialized stack data in padding Richard Palethorpe
2020-04-01 10:08 ` Marc Kleine-Budde
2020-04-01 18:23 ` David Miller [this message]
2020-04-01 19:41 ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).