* [PATCH] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035
@ 2020-04-01 9:57 Oleksij Rempel
2020-04-01 17:17 ` Russell King - ARM Linux admin
2020-04-01 18:21 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Oleksij Rempel @ 2020-04-01 9:57 UTC (permalink / raw)
To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
Rob Herring, Sascha Hauer, Shawn Guo
Cc: Oleksij Rempel, Russell King, David Jander, David S. Miller,
devicetree, Fabio Estevam, kernel, Liam Girdwood,
linux-arm-kernel, linux-imx, linux-kernel, Mark Brown, netdev,
Philippe Schenker
The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set
for the values that comprise the fields, not zero-bits-set.
This patch fixes the clock frequency configuration for ATH8030 and
ATH8035 Atheros PHYs by removing the erroneous "~".
To reproduce this bug, configure the PHY with the device tree binding
"qca,clk-out-frequency" and remove the machine specific PHY fixups.
Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding")
Reported-by: Russell King <linux@armlinux.org.uk>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/phy/at803x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 481cf48c9b9e4..31f731e6df720 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -425,8 +425,8 @@ static int at803x_parse_dt(struct phy_device *phydev)
*/
if (at803x_match_phy_id(phydev, ATH8030_PHY_ID) ||
at803x_match_phy_id(phydev, ATH8035_PHY_ID)) {
- priv->clk_25m_reg &= ~AT8035_CLK_OUT_MASK;
- priv->clk_25m_mask &= ~AT8035_CLK_OUT_MASK;
+ priv->clk_25m_reg &= AT8035_CLK_OUT_MASK;
+ priv->clk_25m_mask &= AT8035_CLK_OUT_MASK;
}
}
--
2.26.0.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035
2020-04-01 9:57 [PATCH] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035 Oleksij Rempel
@ 2020-04-01 17:17 ` Russell King - ARM Linux admin
2020-04-01 18:21 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Russell King - ARM Linux admin @ 2020-04-01 17:17 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
Rob Herring, Sascha Hauer, Shawn Guo, David Jander,
David S. Miller, devicetree, Fabio Estevam, kernel,
Liam Girdwood, linux-arm-kernel, linux-imx, linux-kernel,
Mark Brown, netdev, Philippe Schenker
On Wed, Apr 01, 2020 at 11:57:32AM +0200, Oleksij Rempel wrote:
> The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set
> for the values that comprise the fields, not zero-bits-set.
>
> This patch fixes the clock frequency configuration for ATH8030 and
> ATH8035 Atheros PHYs by removing the erroneous "~".
>
> To reproduce this bug, configure the PHY with the device tree binding
> "qca,clk-out-frequency" and remove the machine specific PHY fixups.
>
> Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding")
> Reported-by: Russell King <linux@armlinux.org.uk>
Please replace this with:
Reported-by: Russell King <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Tested-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> ---
> drivers/net/phy/at803x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
> index 481cf48c9b9e4..31f731e6df720 100644
> --- a/drivers/net/phy/at803x.c
> +++ b/drivers/net/phy/at803x.c
> @@ -425,8 +425,8 @@ static int at803x_parse_dt(struct phy_device *phydev)
> */
> if (at803x_match_phy_id(phydev, ATH8030_PHY_ID) ||
> at803x_match_phy_id(phydev, ATH8035_PHY_ID)) {
> - priv->clk_25m_reg &= ~AT8035_CLK_OUT_MASK;
> - priv->clk_25m_mask &= ~AT8035_CLK_OUT_MASK;
> + priv->clk_25m_reg &= AT8035_CLK_OUT_MASK;
> + priv->clk_25m_mask &= AT8035_CLK_OUT_MASK;
> }
> }
>
> --
> 2.26.0.rc2
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035
2020-04-01 9:57 [PATCH] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035 Oleksij Rempel
2020-04-01 17:17 ` Russell King - ARM Linux admin
@ 2020-04-01 18:21 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-04-01 18:21 UTC (permalink / raw)
To: o.rempel
Cc: andrew, f.fainelli, hkallweit1, mark.rutland, robh+dt, s.hauer,
shawnguo, linux, david, devicetree, festevam, kernel, lgirdwood,
linux-arm-kernel, linux-imx, linux-kernel, broonie, netdev,
philippe.schenker
From: Oleksij Rempel <o.rempel@pengutronix.de>
Date: Wed, 1 Apr 2020 11:57:32 +0200
> The masks in priv->clk_25m_reg and priv->clk_25m_mask are one-bits-set
> for the values that comprise the fields, not zero-bits-set.
>
> This patch fixes the clock frequency configuration for ATH8030 and
> ATH8035 Atheros PHYs by removing the erroneous "~".
>
> To reproduce this bug, configure the PHY with the device tree binding
> "qca,clk-out-frequency" and remove the machine specific PHY fixups.
>
> Fixes: 2f664823a47021 ("net: phy: at803x: add device tree binding")
> Reported-by: Russell King <linux@armlinux.org.uk>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Applied with Reported-by: fixed and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-01 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-01 9:57 [PATCH] net: phy: at803x: fix clock sink configuration on ATH8030 and ATH8035 Oleksij Rempel
2020-04-01 17:17 ` Russell King - ARM Linux admin
2020-04-01 18:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).