* [PATCH net-next] ptp: idt82p33: remove unnecessary comparison
@ 2020-04-24 8:03 Yang Yingliang
2020-04-24 23:59 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2020-04-24 8:03 UTC (permalink / raw)
To: richardcochran, min.li.xe, davem, yangyingliang; +Cc: netdev, linux-kernel
The type of loaddr is u8 which is always '<=' 0xff, so the
loaddr <= 0xff is always true, we can remove this comparison.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/ptp/ptp_idt82p33.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c
index 31ea811..179f6c4 100644
--- a/drivers/ptp/ptp_idt82p33.c
+++ b/drivers/ptp/ptp_idt82p33.c
@@ -881,7 +881,7 @@ static int idt82p33_load_firmware(struct idt82p33 *idt82p33)
/* Page size 128, last 4 bytes of page skipped */
if (((loaddr > 0x7b) && (loaddr <= 0x7f))
- || ((loaddr > 0xfb) && (loaddr <= 0xff)))
+ || loaddr > 0xfb)
continue;
err = idt82p33_write(idt82p33, _ADDR(page, loaddr),
--
1.8.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] ptp: idt82p33: remove unnecessary comparison
2020-04-24 8:03 [PATCH net-next] ptp: idt82p33: remove unnecessary comparison Yang Yingliang
@ 2020-04-24 23:59 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-04-24 23:59 UTC (permalink / raw)
To: yangyingliang; +Cc: richardcochran, min.li.xe, netdev, linux-kernel
From: Yang Yingliang <yangyingliang@huawei.com>
Date: Fri, 24 Apr 2020 16:03:48 +0800
> The type of loaddr is u8 which is always '<=' 0xff, so the
> loaddr <= 0xff is always true, we can remove this comparison.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-24 23:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-24 8:03 [PATCH net-next] ptp: idt82p33: remove unnecessary comparison Yang Yingliang
2020-04-24 23:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).