[PATCH] ptp_qoriq: output PPS signal on FIPER2 in default

[PATCH] ptp_qoriq: output PPS signal on FIPER2 in default

[Yangbo Lu]

Output PPS signal on FIPER2 (Fixed Period Interval Pulse) in default
which is more desired by user.

Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
 include/linux/fsl/ptp_qoriq.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/fsl/ptp_qoriq.h b/include/linux/fsl/ptp_qoriq.h
index 7588456..884b8f8 100644
--- a/include/linux/fsl/ptp_qoriq.h
+++ b/include/linux/fsl/ptp_qoriq.h
@@ -135,7 +135,7 @@ struct ptp_qoriq_registers {
 #define DEFAULT_CKSEL		1
 #define DEFAULT_TMR_PRSC	2
 #define DEFAULT_FIPER1_PERIOD	1000000000
-#define DEFAULT_FIPER2_PERIOD	100000
+#define DEFAULT_FIPER2_PERIOD	1000000000
 
 struct ptp_qoriq {
 	void __iomem *base;
-- 
2.7.4

Re: [PATCH] ptp_qoriq: output PPS signal on FIPER2 in default

[Richard Cochran]

On Mon, Apr 27, 2020 at 11:39:03AM +0800, Yangbo Lu wrote:
> Output PPS signal on FIPER2 (Fixed Period Interval Pulse) in default
> which is more desired by user.

FIPER1 is already 1-PPS by default, and the user can load anything
they want in the device tree, so I don't really see the need for this
change.

But, I am not really opposed to it, either.

Thanks,
Richard

RE: [PATCH] ptp_qoriq: output PPS signal on FIPER2 in default

[Y.b. Lu]

> -----Original Message-----
> From: Richard Cochran <richardcochran@gmail.com>
> Sent: Monday, April 27, 2020 9:52 PM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: netdev@vger.kernel.org; David S . Miller <davem@davemloft.net>; Leo Li
> <leoyang.li@nxp.com>
> Subject: Re: [PATCH] ptp_qoriq: output PPS signal on FIPER2 in default
> 
> On Mon, Apr 27, 2020 at 11:39:03AM +0800, Yangbo Lu wrote:
> > Output PPS signal on FIPER2 (Fixed Period Interval Pulse) in default
> > which is more desired by user.
> 
> FIPER1 is already 1-PPS by default, and the user can load anything
> they want in the device tree, so I don't really see the need for this
> change.
> 
> But, I am not really opposed to it, either.

Thanks a lot, Richard.
Yes, I understand. I just think as the default configuration, PPS may be properer than 100 us period pulse which I don't know used for.

> 
> Thanks,
> Richard

Re: [PATCH] ptp_qoriq: output PPS signal on FIPER2 in default

[David Miller]

From: Yangbo Lu <yangbo.lu@nxp.com>
Date: Mon, 27 Apr 2020 11:39:03 +0800

> Output PPS signal on FIPER2 (Fixed Period Interval Pulse) in default
> which is more desired by user.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>

Applied to net-next, thanks.