netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] libxt_addrtype.c - include strings.h for the definition of ffs()
@ 2020-04-21  8:15 Maciej Żenczykowski
  2020-04-28  0:04 ` Pablo Neira Ayuso
  0 siblings, 1 reply; 2+ messages in thread
From: Maciej Żenczykowski @ 2020-04-21  8:15 UTC (permalink / raw)
  To: Maciej Żenczykowski, Pablo Neira Ayuso, Florian Westphal
  Cc: Linux Network Development Mailing List,
	Netfilter Development Mailing List

From: Maciej Żenczykowski <maze@google.com>

This resolves compiler warning:

extensions/libext_srcs/gen/gensrcs/external/iptables/extensions/libxt_addrtype.c:263:14: error: implicit declaration of function 'ffs' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
  int first = ffs(val);
              ^

Test: builds with less warnings
Signed-off-by: Maciej Żenczykowski <maze@google.com>
---
 extensions/libxt_addrtype.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/extensions/libxt_addrtype.c b/extensions/libxt_addrtype.c
index 27485405..5cafa219 100644
--- a/extensions/libxt_addrtype.c
+++ b/extensions/libxt_addrtype.c
@@ -5,6 +5,7 @@
  * This program is released under the terms of GNU GPL */
 #include <stdio.h>
 #include <string.h>
+#include <strings.h>
 #include <xtables.h>
 #include <linux/netfilter/xt_addrtype.h>
 
-- 
2.26.1.301.g55bc3eb7cb9-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] libxt_addrtype.c - include strings.h for the definition of ffs()
  2020-04-21  8:15 [PATCH] libxt_addrtype.c - include strings.h for the definition of ffs() Maciej Żenczykowski
@ 2020-04-28  0:04 ` Pablo Neira Ayuso
  0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2020-04-28  0:04 UTC (permalink / raw)
  To: Maciej Żenczykowski
  Cc: Maciej Żenczykowski, Florian Westphal,
	Linux Network Development Mailing List,
	Netfilter Development Mailing List

I have squashed this to the previous patch.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-28  0:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-21  8:15 [PATCH] libxt_addrtype.c - include strings.h for the definition of ffs() Maciej Żenczykowski
2020-04-28  0:04 ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).