* [PATCH -next] hinic: make symbol 'dump_mox_reg' static
@ 2020-04-29 1:58 Zheng Bin
2020-05-01 3:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Bin @ 2020-04-29 1:58 UTC (permalink / raw)
To: aviad.krawczyk, davem, netdev; +Cc: zhengbin13
Fix sparse warnings:
drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:601:6: warning: symbol 'dump_mox_reg' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c b/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c
index f8626dfd192e..d5cf31529dbf 100644
--- a/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c
+++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c
@@ -598,7 +598,7 @@ static void write_mbox_msg_attr(struct hinic_mbox_func_to_func *func_to_func,
HINIC_FUNC_CSR_MAILBOX_CONTROL_OFF, mbox_ctrl);
}
-void dump_mox_reg(struct hinic_hwdev *hwdev)
+static void dump_mox_reg(struct hinic_hwdev *hwdev)
{
u32 val;
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] hinic: make symbol 'dump_mox_reg' static
2020-04-29 1:58 [PATCH -next] hinic: make symbol 'dump_mox_reg' static Zheng Bin
@ 2020-05-01 3:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-05-01 3:58 UTC (permalink / raw)
To: zhengbin13; +Cc: aviad.krawczyk, netdev
From: Zheng Bin <zhengbin13@huawei.com>
Date: Wed, 29 Apr 2020 09:58:24 +0800
> Fix sparse warnings:
>
> drivers/net/ethernet/huawei/hinic/hinic_hw_mbox.c:601:6: warning: symbol 'dump_mox_reg' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-01 3:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 1:58 [PATCH -next] hinic: make symbol 'dump_mox_reg' static Zheng Bin
2020-05-01 3:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).