From: Song Liu <songliubraving@fb.com>
To: <bpf@vger.kernel.org>, <netdev@vger.kernel.org>
Cc: <ast@kernel.org>, <daniel@iogearbox.net>, <kernel-team@fb.com>,
Song Liu <songliubraving@fb.com>
Subject: [PATCH v7 bpf-next 0/3] bpf: sharing bpf runtime stats with
Date: Tue, 28 Apr 2020 20:58:38 -0700 [thread overview]
Message-ID: <20200429035841.3959159-1-songliubraving@fb.com> (raw)
run_time_ns is a useful stats for BPF programs. However, it is gated by
sysctl kernel.bpf_stats_enabled. When multiple user space tools are
toggling kernl.bpf_stats_enabled at the same time, they may confuse each
other.
Solve this problem with a new BPF command BPF_ENABLE_STATS.
Changes v6 => v7:
1. Add test to verify run_cnt matches count measured by the program.
Changes v5 => v6:
1. Simplify test program (Yonghong).
2. Rebase (with some conflicts).
Changes v4 => v5:
1. Use memset to zero bpf_attr in bpf_enable_stats() (Andrii).
Changes v3 => v4:
1. Add libbpf support and selftest;
2. Avoid cleaning trailing space.
Changes v2 => v3:
1. Rename the command to BPF_ENABLE_STATS, and make it extendible.
2. fix commit log;
3. remove unnecessary headers.
Song Liu (3):
bpf: sharing bpf runtime stats with BPF_ENABLE_STATS
libbpf: add support for command BPF_ENABLE_STATS
bpf: add selftest for BPF_ENABLE_STATS
include/linux/bpf.h | 1 +
include/uapi/linux/bpf.h | 11 ++++
kernel/bpf/syscall.c | 50 ++++++++++++++++
kernel/sysctl.c | 37 +++++++++++-
tools/include/uapi/linux/bpf.h | 11 ++++
tools/lib/bpf/bpf.c | 10 ++++
tools/lib/bpf/bpf.h | 1 +
tools/lib/bpf/libbpf.map | 5 ++
.../selftests/bpf/prog_tests/enable_stats.c | 58 +++++++++++++++++++
.../selftests/bpf/progs/test_enable_stats.c | 18 ++++++
10 files changed, 200 insertions(+), 2 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/enable_stats.c
create mode 100644 tools/testing/selftests/bpf/progs/test_enable_stats.c
--
2.24.1
next reply other threads:[~2020-04-29 3:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 3:58 Song Liu [this message]
2020-04-29 3:58 ` [PATCH v7 bpf-next 1/3] bpf: sharing bpf runtime stats with BPF_ENABLE_STATS Song Liu
2020-04-29 4:39 ` Alexei Starovoitov
2020-04-29 3:58 ` [PATCH v7 bpf-next 2/3] libbpf: add support for command BPF_ENABLE_STATS Song Liu
2020-04-29 5:32 ` Andrii Nakryiko
2020-04-29 5:36 ` Song Liu
2020-04-29 3:58 ` [PATCH v7 bpf-next 3/3] bpf: add selftest for BPF_ENABLE_STATS Song Liu
2020-04-29 4:57 ` Alexei Starovoitov
2020-04-29 5:32 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429035841.3959159-1-songliubraving@fb.com \
--to=songliubraving@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).