From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Song Liu <songliubraving@fb.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, kernel-team@fb.com
Subject: Re: [PATCH v7 bpf-next 1/3] bpf: sharing bpf runtime stats with BPF_ENABLE_STATS
Date: Tue, 28 Apr 2020 21:39:40 -0700 [thread overview]
Message-ID: <20200429043940.6dirzvgh26o2hrul@ast-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200429035841.3959159-2-songliubraving@fb.com>
On Tue, Apr 28, 2020 at 08:58:39PM -0700, Song Liu wrote:
> +
> +static int bpf_enable_stats(union bpf_attr *attr)
> +{
CHECK_ATTR() is missing which makes it non-extensible.
> + switch (attr->enable_stats.type) {
> + case BPF_STATS_RUNTIME_CNT:
> + return bpf_enable_runtime_stats();
> + default:
> + break;
> + }
> + return -EINVAL;
> +}
next prev parent reply other threads:[~2020-04-29 4:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-29 3:58 [PATCH v7 bpf-next 0/3] bpf: sharing bpf runtime stats with Song Liu
2020-04-29 3:58 ` [PATCH v7 bpf-next 1/3] bpf: sharing bpf runtime stats with BPF_ENABLE_STATS Song Liu
2020-04-29 4:39 ` Alexei Starovoitov [this message]
2020-04-29 3:58 ` [PATCH v7 bpf-next 2/3] libbpf: add support for command BPF_ENABLE_STATS Song Liu
2020-04-29 5:32 ` Andrii Nakryiko
2020-04-29 5:36 ` Song Liu
2020-04-29 3:58 ` [PATCH v7 bpf-next 3/3] bpf: add selftest for BPF_ENABLE_STATS Song Liu
2020-04-29 4:57 ` Alexei Starovoitov
2020-04-29 5:32 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429043940.6dirzvgh26o2hrul@ast-mbp.dhcp.thefacebook.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).