From: Stephen Hemminger <stephen@networkplumber.org>
To: Benjamin Poirier <bpoirier@cumulusnetworks.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 0/7] bridge vlan output fixes
Date: Wed, 29 Apr 2020 22:35:34 -0700 [thread overview]
Message-ID: <20200429223534.6f72095c@hermes.lan> (raw)
In-Reply-To: <20200427235051.250058-1-bpoirier@cumulusnetworks.com>
On Tue, 28 Apr 2020 08:50:44 +0900
Benjamin Poirier <bpoirier@cumulusnetworks.com> wrote:
> More fixes for `bridge vlan` and `bridge vlan tunnelshow` normal and JSON
> mode output.
>
> Most of the changes are cosmetic except for changes to JSON format (flag
> names, no empty lists).
>
> Benjamin Poirier (7):
> bridge: Use the same flag names in input and output
> bridge: Use consistent column names in vlan output
> bridge: Fix typo
> bridge: Fix output with empty vlan lists
> json_print: Return number of characters printed
> bridge: Align output columns
> Replace open-coded instances of print_nl()
>
> bridge/vlan.c | 115 +++++++++++++++--------
> include/json_print.h | 24 +++--
> lib/json_print.c | 95 ++++++++++++-------
> tc/m_action.c | 14 +--
> tc/m_connmark.c | 4 +-
> tc/m_ctinfo.c | 4 +-
> tc/m_ife.c | 4 +-
> tc/m_mpls.c | 2 +-
> tc/m_nat.c | 4 +-
> tc/m_sample.c | 4 +-
> tc/m_skbedit.c | 4 +-
> tc/m_tunnel_key.c | 16 ++--
> tc/q_taprio.c | 8 +-
> tc/tc_util.c | 4 +-
> testsuite/tests/bridge/vlan/show.t | 30 ++++++
> testsuite/tests/bridge/vlan/tunnelshow.t | 2 +-
> 16 files changed, 212 insertions(+), 122 deletions(-)
> create mode 100755 testsuite/tests/bridge/vlan/show.t
>
Most of these look fine. Resend after the the first patch discussion
has resolved.
prev parent reply other threads:[~2020-04-30 5:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 23:50 [PATCH iproute2 0/7] bridge vlan output fixes Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 1/7] bridge: Use the same flag names in input and output Benjamin Poirier
2020-04-29 15:12 ` Roopa Prabhu
2020-04-30 0:22 ` Benjamin Poirier
2020-04-30 0:58 ` Nikolay Aleksandrov
2020-04-27 23:50 ` [PATCH iproute2 2/7] bridge: Use consistent column names in vlan output Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 3/7] bridge: Fix typo Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 4/7] bridge: Fix output with empty vlan lists Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 5/7] json_print: Return number of characters printed Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 6/7] bridge: Align output columns Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 7/7] Replace open-coded instances of print_nl() Benjamin Poirier
2020-04-30 5:35 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200429223534.6f72095c@hermes.lan \
--to=stephen@networkplumber.org \
--cc=bpoirier@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).