From: Roopa Prabhu <roopa@cumulusnetworks.com>
To: Benjamin Poirier <bpoirier@cumulusnetworks.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2 1/7] bridge: Use the same flag names in input and output
Date: Wed, 29 Apr 2020 08:12:14 -0700 [thread overview]
Message-ID: <CAJieiUh0c1LCud2ZNuD5MygrBO=Yb1OgqHawxjgkX1j+6NHMrQ@mail.gmail.com> (raw)
In-Reply-To: <20200427235051.250058-2-bpoirier@cumulusnetworks.com>
On Mon, Apr 27, 2020 at 4:51 PM Benjamin Poirier
<bpoirier@cumulusnetworks.com> wrote:
>
> Output the same names for vlan flags as the ones accepted in command input.
>
> Signed-off-by: Benjamin Poirier <bpoirier@cumulusnetworks.com>
> ---
Benjamin, It's a good change, but this will break existing users ?.
> bridge/vlan.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/bridge/vlan.c b/bridge/vlan.c
> index 205851e4..08b19897 100644
> --- a/bridge/vlan.c
> +++ b/bridge/vlan.c
> @@ -398,10 +398,10 @@ static void print_vlan_flags(__u16 flags)
>
> open_json_array(PRINT_JSON, "flags");
> if (flags & BRIDGE_VLAN_INFO_PVID)
> - print_string(PRINT_ANY, NULL, " %s", "PVID");
> + print_string(PRINT_ANY, NULL, " %s", "pvid");
>
> if (flags & BRIDGE_VLAN_INFO_UNTAGGED)
> - print_string(PRINT_ANY, NULL, " %s", "Egress Untagged");
> + print_string(PRINT_ANY, NULL, " %s", "untagged");
> close_json_array(PRINT_JSON, NULL);
> }
>
> --
> 2.26.0
>
next prev parent reply other threads:[~2020-04-29 15:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 23:50 [PATCH iproute2 0/7] bridge vlan output fixes Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 1/7] bridge: Use the same flag names in input and output Benjamin Poirier
2020-04-29 15:12 ` Roopa Prabhu [this message]
2020-04-30 0:22 ` Benjamin Poirier
2020-04-30 0:58 ` Nikolay Aleksandrov
2020-04-27 23:50 ` [PATCH iproute2 2/7] bridge: Use consistent column names in vlan output Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 3/7] bridge: Fix typo Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 4/7] bridge: Fix output with empty vlan lists Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 5/7] json_print: Return number of characters printed Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 6/7] bridge: Align output columns Benjamin Poirier
2020-04-27 23:50 ` [PATCH iproute2 7/7] Replace open-coded instances of print_nl() Benjamin Poirier
2020-04-30 5:35 ` [PATCH iproute2 0/7] bridge vlan output fixes Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJieiUh0c1LCud2ZNuD5MygrBO=Yb1OgqHawxjgkX1j+6NHMrQ@mail.gmail.com' \
--to=roopa@cumulusnetworks.com \
--cc=bpoirier@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).