* [net] ice: cleanup language in ice.rst for fw.app
@ 2020-04-29 20:59 Jacob Keller
2020-04-29 21:09 ` Jakub Kicinski
2020-05-01 22:30 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Jacob Keller @ 2020-04-29 20:59 UTC (permalink / raw)
To: netdev; +Cc: Jeffrey Kirsher, Jakub Kicinski, Jacob Keller, Benjamin Fisher
The documentation for the ice driver around "fw.app" has a spelling
mistake in variation. Additionally, the language of "shall have a unique
name" sounds like a requirement. Reword this to read more like
a description or property.
Reported-by: Benjamin Fisher <benjamin.l.fisher@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
Documentation/networking/devlink/ice.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/networking/devlink/ice.rst b/Documentation/networking/devlink/ice.rst
index 5b58fc4e1268..4574352d6ff4 100644
--- a/Documentation/networking/devlink/ice.rst
+++ b/Documentation/networking/devlink/ice.rst
@@ -61,8 +61,8 @@ The ``ice`` driver reports the following versions
- running
- ICE OS Default Package
- The name of the DDP package that is active in the device. The DDP
- package is loaded by the driver during initialization. Each varation
- of DDP package shall have a unique name.
+ package is loaded by the driver during initialization. Each
+ variation of the DDP package has a unique name.
* - ``fw.app``
- running
- 1.3.1.0
--
2.25.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [net] ice: cleanup language in ice.rst for fw.app
2020-04-29 20:59 [net] ice: cleanup language in ice.rst for fw.app Jacob Keller
@ 2020-04-29 21:09 ` Jakub Kicinski
2020-04-29 21:13 ` Kirsher, Jeffrey T
2020-05-01 22:30 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2020-04-29 21:09 UTC (permalink / raw)
To: Jacob Keller; +Cc: netdev, Jeffrey Kirsher, Benjamin Fisher
On Wed, 29 Apr 2020 13:59:50 -0700 Jacob Keller wrote:
> The documentation for the ice driver around "fw.app" has a spelling
> mistake in variation. Additionally, the language of "shall have a unique
> name" sounds like a requirement. Reword this to read more like
> a description or property.
>
> Reported-by: Benjamin Fisher <benjamin.l.fisher@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Jakub Kicinski <kubakici@wp.pl>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [net] ice: cleanup language in ice.rst for fw.app
2020-04-29 21:09 ` Jakub Kicinski
@ 2020-04-29 21:13 ` Kirsher, Jeffrey T
0 siblings, 0 replies; 4+ messages in thread
From: Kirsher, Jeffrey T @ 2020-04-29 21:13 UTC (permalink / raw)
To: Jakub Kicinski, Keller, Jacob E; +Cc: netdev, Fisher, Benjamin L
> -----Original Message-----
> From: Jakub Kicinski <kubakici@wp.pl>
> Sent: Wednesday, April 29, 2020 14:09
> To: Keller, Jacob E <jacob.e.keller@intel.com>
> Cc: netdev@vger.kernel.org; Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>;
> Fisher, Benjamin L <benjamin.l.fisher@intel.com>
> Subject: Re: [net] ice: cleanup language in ice.rst for fw.app
>
> On Wed, 29 Apr 2020 13:59:50 -0700 Jacob Keller wrote:
> > The documentation for the ice driver around "fw.app" has a spelling
> > mistake in variation. Additionally, the language of "shall have a
> > unique name" sounds like a requirement. Reword this to read more like
> > a description or property.
> >
> > Reported-by: Benjamin Fisher <benjamin.l.fisher@intel.com>
> > Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
>
> Acked-by: Jakub Kicinski <kubakici@wp.pl>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [net] ice: cleanup language in ice.rst for fw.app
2020-04-29 20:59 [net] ice: cleanup language in ice.rst for fw.app Jacob Keller
2020-04-29 21:09 ` Jakub Kicinski
@ 2020-05-01 22:30 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2020-05-01 22:30 UTC (permalink / raw)
To: jacob.e.keller; +Cc: netdev, jeffrey.t.kirsher, kubakici, benjamin.l.fisher
From: Jacob Keller <jacob.e.keller@intel.com>
Date: Wed, 29 Apr 2020 13:59:50 -0700
> The documentation for the ice driver around "fw.app" has a spelling
> mistake in variation. Additionally, the language of "shall have a unique
> name" sounds like a requirement. Reword this to read more like
> a description or property.
>
> Reported-by: Benjamin Fisher <benjamin.l.fisher@intel.com>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-01 22:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-29 20:59 [net] ice: cleanup language in ice.rst for fw.app Jacob Keller
2020-04-29 21:09 ` Jakub Kicinski
2020-04-29 21:13 ` Kirsher, Jeffrey T
2020-05-01 22:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).