* [PATCH next] ARM: dts: am437x: fix networking on boards with ksz9031 phy
@ 2020-05-06 19:08 Grygorii Strashko
2020-05-07 4:40 ` Oleksij Rempel
0 siblings, 1 reply; 3+ messages in thread
From: Grygorii Strashko @ 2020-05-06 19:08 UTC (permalink / raw)
To: Tony Lindgren, David S. Miller
Cc: netdev, linux-kernel, linux-omap, Grygorii Strashko,
Oleksij Rempel, Andrew Lunn, Philippe Schenker
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") the networking is broken on boards:
am437x-gp-evm
am437x-sk-evm
am437x-idk-evm
All above boards have phy-mode = "rgmii" and this is worked before, because
KSZ9031 PHY started with default RGMII internal delays configuration (TX
off, RX on 1.2 ns) and MAC provided TX delay. After above commit, the
KSZ9031 PHY starts handling phy mode properly and disables RX delay, as
result networking is become broken.
Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
behavior.
Cc: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>
Cc: Philippe Schenker <philippe.schenker@toradex.com>
Fixes: commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
arch/arm/boot/dts/am437x-idk-evm.dts | 2 +-
arch/arm/boot/dts/am437x-sk-evm.dts | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
index 811c8cae315b..d692e3b2812a 100644
--- a/arch/arm/boot/dts/am437x-gp-evm.dts
+++ b/arch/arm/boot/dts/am437x-gp-evm.dts
@@ -943,7 +943,7 @@
&cpsw_emac0 {
phy-handle = <ðphy0>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-rxid";
};
&elm {
diff --git a/arch/arm/boot/dts/am437x-idk-evm.dts b/arch/arm/boot/dts/am437x-idk-evm.dts
index 9f66f96d09c9..a7495fb364bf 100644
--- a/arch/arm/boot/dts/am437x-idk-evm.dts
+++ b/arch/arm/boot/dts/am437x-idk-evm.dts
@@ -504,7 +504,7 @@
&cpsw_emac0 {
phy-handle = <ðphy0>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
};
&rtc {
diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
index 25222497f828..4d5a7ca2e25d 100644
--- a/arch/arm/boot/dts/am437x-sk-evm.dts
+++ b/arch/arm/boot/dts/am437x-sk-evm.dts
@@ -833,13 +833,13 @@
&cpsw_emac0 {
phy-handle = <ðphy0>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-rxid";
dual_emac_res_vlan = <1>;
};
&cpsw_emac1 {
phy-handle = <ðphy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-rxid";
dual_emac_res_vlan = <2>;
};
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH next] ARM: dts: am437x: fix networking on boards with ksz9031 phy
2020-05-06 19:08 [PATCH next] ARM: dts: am437x: fix networking on boards with ksz9031 phy Grygorii Strashko
@ 2020-05-07 4:40 ` Oleksij Rempel
2020-05-07 15:13 ` Grygorii Strashko
0 siblings, 1 reply; 3+ messages in thread
From: Oleksij Rempel @ 2020-05-07 4:40 UTC (permalink / raw)
To: Grygorii Strashko
Cc: Tony Lindgren, David S. Miller, netdev, linux-kernel, linux-omap,
Andrew Lunn, Philippe Schenker
[-- Attachment #1: Type: text/plain, Size: 2928 bytes --]
Hi Grygorii,
thank you for you patches!
On Wed, May 06, 2020 at 10:08:35PM +0300, Grygorii Strashko wrote:
> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
> KSZ9031 PHY") the networking is broken on boards:
> am437x-gp-evm
> am437x-sk-evm
> am437x-idk-evm
>
> All above boards have phy-mode = "rgmii" and this is worked before, because
> KSZ9031 PHY started with default RGMII internal delays configuration (TX
> off, RX on 1.2 ns) and MAC provided TX delay. After above commit, the
> KSZ9031 PHY starts handling phy mode properly and disables RX delay, as
> result networking is become broken.
>
> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
> behavior.
>
> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
> Cc: Andrew Lunn <andrew@lunn.ch>
> Cc: Philippe Schenker <philippe.schenker@toradex.com>
> Fixes: commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
> arch/arm/boot/dts/am437x-idk-evm.dts | 2 +-
> arch/arm/boot/dts/am437x-sk-evm.dts | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
> index 811c8cae315b..d692e3b2812a 100644
> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
> @@ -943,7 +943,7 @@
>
> &cpsw_emac0 {
> phy-handle = <ðphy0>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-rxid";
> };
>
> &elm {
> diff --git a/arch/arm/boot/dts/am437x-idk-evm.dts b/arch/arm/boot/dts/am437x-idk-evm.dts
> index 9f66f96d09c9..a7495fb364bf 100644
> --- a/arch/arm/boot/dts/am437x-idk-evm.dts
> +++ b/arch/arm/boot/dts/am437x-idk-evm.dts
> @@ -504,7 +504,7 @@
>
> &cpsw_emac0 {
> phy-handle = <ðphy0>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> };
Do you have here really rgmii-id?
> &rtc {
> diff --git a/arch/arm/boot/dts/am437x-sk-evm.dts b/arch/arm/boot/dts/am437x-sk-evm.dts
> index 25222497f828..4d5a7ca2e25d 100644
> --- a/arch/arm/boot/dts/am437x-sk-evm.dts
> +++ b/arch/arm/boot/dts/am437x-sk-evm.dts
> @@ -833,13 +833,13 @@
>
> &cpsw_emac0 {
> phy-handle = <ðphy0>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-rxid";
> dual_emac_res_vlan = <1>;
> };
>
> &cpsw_emac1 {
> phy-handle = <ðphy1>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-rxid";
> dual_emac_res_vlan = <2>;
> };
>
> --
> 2.17.1
Regards,
Oleksij
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH next] ARM: dts: am437x: fix networking on boards with ksz9031 phy
2020-05-07 4:40 ` Oleksij Rempel
@ 2020-05-07 15:13 ` Grygorii Strashko
0 siblings, 0 replies; 3+ messages in thread
From: Grygorii Strashko @ 2020-05-07 15:13 UTC (permalink / raw)
To: Oleksij Rempel
Cc: Tony Lindgren, David S. Miller, netdev, linux-kernel, linux-omap,
Andrew Lunn, Philippe Schenker
On 07/05/2020 07:40, Oleksij Rempel wrote:
> Hi Grygorii,
>
> thank you for you patches!
>
> On Wed, May 06, 2020 at 10:08:35PM +0300, Grygorii Strashko wrote:
>> Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
>> KSZ9031 PHY") the networking is broken on boards:
>> am437x-gp-evm
>> am437x-sk-evm
>> am437x-idk-evm
>>
>> All above boards have phy-mode = "rgmii" and this is worked before, because
>> KSZ9031 PHY started with default RGMII internal delays configuration (TX
>> off, RX on 1.2 ns) and MAC provided TX delay. After above commit, the
>> KSZ9031 PHY starts handling phy mode properly and disables RX delay, as
>> result networking is become broken.
>>
>> Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous
>> behavior.
>>
>> Cc: Oleksij Rempel <o.rempel@pengutronix.de>
>> Cc: Andrew Lunn <andrew@lunn.ch>
>> Cc: Philippe Schenker <philippe.schenker@toradex.com>
>> Fixes: commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY")
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>> arch/arm/boot/dts/am437x-gp-evm.dts | 2 +-
>> arch/arm/boot/dts/am437x-idk-evm.dts | 2 +-
>> arch/arm/boot/dts/am437x-sk-evm.dts | 4 ++--
>> 3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts
>> index 811c8cae315b..d692e3b2812a 100644
>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts
>> @@ -943,7 +943,7 @@
>>
>> &cpsw_emac0 {
>> phy-handle = <ðphy0>;
>> - phy-mode = "rgmii";
>> + phy-mode = "rgmii-rxid";
>> };
>>
>> &elm {
>> diff --git a/arch/arm/boot/dts/am437x-idk-evm.dts b/arch/arm/boot/dts/am437x-idk-evm.dts
>> index 9f66f96d09c9..a7495fb364bf 100644
>> --- a/arch/arm/boot/dts/am437x-idk-evm.dts
>> +++ b/arch/arm/boot/dts/am437x-idk-evm.dts
>> @@ -504,7 +504,7 @@
>>
>> &cpsw_emac0 {
>> phy-handle = <ðphy0>;
>> - phy-mode = "rgmii";
>> + phy-mode = "rgmii-id";
>> };
>
> Do you have here really rgmii-id?
>
Right, thanks you.
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-07 15:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-06 19:08 [PATCH next] ARM: dts: am437x: fix networking on boards with ksz9031 phy Grygorii Strashko
2020-05-07 4:40 ` Oleksij Rempel
2020-05-07 15:13 ` Grygorii Strashko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).