From: Olivier Dautricourt <olivier.dautricourt@orolia.com>
To: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>
Cc: Richard Cochran <richardcochran@gmail.com>,
netdev@vger.kernel.org,
Olivier Dautricourt <olivier.dautricourt@orolia.com>
Subject: [PATCH 2/3] net: uapi: Add HWTSTAMP_FLAGS_ADJ_FINE/ADJ_COARSE
Date: Thu, 14 May 2020 12:28:07 +0200 [thread overview]
Message-ID: <20200514102808.31163-3-olivier.dautricourt@orolia.com> (raw)
In-Reply-To: <20200514102808.31163-1-olivier.dautricourt@orolia.com>
This commit allows a user to specify a flag value for configuring
timestamping through hwtsamp_config structure.
New flags introduced:
HWTSTAMP_FLAGS_NONE = 0
No flag specified: as it is of value 0, this will selects the
default behavior for all the existing drivers and should not
break existing userland programs.
HWTSTAMP_FLAGS_ADJ_FINE = 1
Use the fine adjustment mode.
Fine adjustment mode is usually used for precise frequency adjustments.
HWTSTAMP_FLAGS_ADJ_COARSE = 2
Use the coarse adjustment mode
Coarse adjustment mode is usually used for direct phase correction.
Signed-off-by: Olivier Dautricourt <olivier.dautricourt@orolia.com>
---
include/uapi/linux/net_tstamp.h | 12 ++++++++++++
net/core/dev_ioctl.c | 3 ---
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/uapi/linux/net_tstamp.h b/include/uapi/linux/net_tstamp.h
index 7ed0b3d1c00a..0cfcd490228f 100644
--- a/include/uapi/linux/net_tstamp.h
+++ b/include/uapi/linux/net_tstamp.h
@@ -65,6 +65,18 @@ struct hwtstamp_config {
int rx_filter;
};
+/* possible values for hwtstamp_config->flags */
+enum hwtsamp_flags {
+ /* No special flag specified */
+ HWTSTAMP_FLAGS_NONE,
+
+ /* Enable fine adjustment mode if the driver supports it */
+ HWTSTAMP_FLAGS_ADJ_FINE,
+
+ /* Enable coarse adjustment mode if the driver supports it */
+ HWTSTAMP_FLAGS_ADJ_COARSE,
+};
+
/* possible values for hwtstamp_config->tx_type */
enum hwtstamp_tx_types {
/*
diff --git a/net/core/dev_ioctl.c b/net/core/dev_ioctl.c
index 547b587c1950..017671545d45 100644
--- a/net/core/dev_ioctl.c
+++ b/net/core/dev_ioctl.c
@@ -177,9 +177,6 @@ static int net_hwtstamp_validate(struct ifreq *ifr)
if (copy_from_user(&cfg, ifr->ifr_data, sizeof(cfg)))
return -EFAULT;
- if (cfg.flags) /* reserved for future extensions */
- return -EINVAL;
-
tx_type = cfg.tx_type;
rx_filter = cfg.rx_filter;
--
2.17.1
next prev parent reply other threads:[~2020-05-14 10:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 10:28 [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock Olivier Dautricourt
2020-05-14 10:28 ` [PATCH 1/3] net: stmmac: gmac3: add auxiliary snapshot support Olivier Dautricourt
2020-05-14 10:28 ` Olivier Dautricourt [this message]
2020-05-14 13:38 ` [PATCH 2/3] net: uapi: Add HWTSTAMP_FLAGS_ADJ_FINE/ADJ_COARSE Richard Cochran
2020-05-14 15:20 ` Olivier Dautricourt
2020-05-15 0:29 ` Richard Cochran
2020-05-14 10:28 ` [PATCH 3/3] net: stmmac: Support coarse mode through ioctl Olivier Dautricourt
2020-05-27 3:55 ` Richard Cochran
2020-06-03 16:12 ` Olivier Dautricourt
2020-05-14 13:53 ` [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock Richard Cochran
2020-05-14 15:09 ` Olivier Dautricourt
2020-05-15 0:37 ` Richard Cochran
2020-05-15 13:26 ` Julien Beraud
2020-05-15 23:30 ` Richard Cochran
2020-05-25 10:00 ` Olivier Dautricourt
2020-05-27 4:05 ` Richard Cochran
2020-06-03 15:17 ` Olivier Dautricourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200514102808.31163-3-olivier.dautricourt@orolia.com \
--to=olivier.dautricourt@orolia.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).