From: Olivier Dautricourt <olivier.dautricourt@orolia.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] net: stmmac: Support coarse mode through ioctl
Date: Wed, 3 Jun 2020 18:12:37 +0200 [thread overview]
Message-ID: <20200603161237.GA26729@orolia.com> (raw)
In-Reply-To: <20200527035509.GA18483@localhost>
The 05/26/2020 20:55, Richard Cochran wrote:
> On Thu, May 14, 2020 at 12:28:08PM +0200, Olivier Dautricourt wrote:
> > The required time adjustment is written in the Timestamp Update registers
> > while the Sub-second increment register is programmed with the period
> > of the clock, which is the precision of our correction.
>
> I don't see in this patch where the "required time adjustment is
> written in the Timestamp Update registers".
>
> What am I missing?
>
> Thanks,
> Richard
This routine already exists in the driver (adjust_systime function).
This one is called on ADJ_SETOFFSET in both functionning modes.
So in both modes the phase jump is done by setting the target time in those
update registers, set a flag and waiting for this flag to be cleared, that
would mean that the correction is effective.
Regards,
--
Olivier Dautricourt
next prev parent reply other threads:[~2020-06-03 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 10:28 [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock Olivier Dautricourt
2020-05-14 10:28 ` [PATCH 1/3] net: stmmac: gmac3: add auxiliary snapshot support Olivier Dautricourt
2020-05-14 10:28 ` [PATCH 2/3] net: uapi: Add HWTSTAMP_FLAGS_ADJ_FINE/ADJ_COARSE Olivier Dautricourt
2020-05-14 13:38 ` Richard Cochran
2020-05-14 15:20 ` Olivier Dautricourt
2020-05-15 0:29 ` Richard Cochran
2020-05-14 10:28 ` [PATCH 3/3] net: stmmac: Support coarse mode through ioctl Olivier Dautricourt
2020-05-27 3:55 ` Richard Cochran
2020-06-03 16:12 ` Olivier Dautricourt [this message]
2020-05-14 13:53 ` [PATCH 0/3] Patch series for a PTP Grandmaster use case using stmmac/gmac3 ptp clock Richard Cochran
2020-05-14 15:09 ` Olivier Dautricourt
2020-05-15 0:37 ` Richard Cochran
2020-05-15 13:26 ` Julien Beraud
2020-05-15 23:30 ` Richard Cochran
2020-05-25 10:00 ` Olivier Dautricourt
2020-05-27 4:05 ` Richard Cochran
2020-06-03 15:17 ` Olivier Dautricourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200603161237.GA26729@orolia.com \
--to=olivier.dautricourt@orolia.com \
--cc=alexandre.torgue@st.com \
--cc=davem@davemloft.net \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).