From: Jakub Kicinski <kuba@kernel.org>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Mark Starovoytov <mstarovoitov@marvell.com>,
Dmitry Bezrukov <dbezrukov@marvell.com>
Subject: Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support
Date: Wed, 20 May 2020 10:08:39 -0700 [thread overview]
Message-ID: <20200520100839.0630f025@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200520134734.2014-4-irusskikh@marvell.com>
On Wed, 20 May 2020 16:47:25 +0300 Igor Russkikh wrote:
> From: Dmitry Bezrukov <dbezrukov@marvell.com>
>
> This patch contains the following changes:
> * add cfg->is_ptp (used for PTP enable/disable switch, which
> is described in more details below);
> * add cfg->tc_mode (A1 supports 2 HW modes only);
> * setup queue to TC mapping based on TC mode on A2;
> * remove hw_tx_tc_mode_get / hw_rx_tc_mode_get hw_ops.
>
> In the first generation of our hardware (A1), a whole traffic class is
> consumed for PTP handling in FW (FW uses it to send the ptp data and to
> send back timestamps).
> Since this conflicts with QoS (user is unable to use the reserved TC2),
> we suggest using module param to give the user a choice: disabling PTP
> allows using all available TCs.
>
> Signed-off-by: Dmitry Bezrukov <dbezrukov@marvell.com>
> Co-developed-by: Mark Starovoytov <mstarovoitov@marvell.com>
> Signed-off-by: Mark Starovoytov <mstarovoitov@marvell.com>
> Signed-off-by: Igor Russkikh <irusskikh@marvell.com>
drivers/net/ethernet/aquantia/atlantic/aq_ptp.c:951:14: warning: no previous prototype for ptp_ring_idx [-Wmissing-prototypes]
951 | unsigned int ptp_ring_idx(const enum aq_tc_mode tc_mode)
| ^~~~~~~~~~~~
next prev parent reply other threads:[~2020-05-20 17:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:47 [PATCH net-next 00/12] net: atlantic: QoS implementation Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 01/12] net: atlantic: changes for multi-TC support Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 02/12] net: atlantic: move PTP TC initialization to a separate function Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 03/12] net: atlantic: changes for multi-TC support Igor Russkikh
2020-05-20 17:08 ` Jakub Kicinski [this message]
2020-05-20 21:01 ` Jakub Kicinski
2020-05-21 9:18 ` [EXT] " Mark Starovoytov
2020-05-21 19:11 ` Jakub Kicinski
2020-05-21 20:38 ` Igor Russkikh
2020-05-21 21:36 ` David Miller
2020-05-20 23:18 ` kbuild test robot
2020-05-21 2:15 ` kbuild test robot
2020-05-21 2:15 ` [RFC PATCH] net: atlantic: ptp_ring_idx() can be static kbuild test robot
2020-05-20 13:47 ` [PATCH net-next 04/12] net: atlantic: QoS implementation: multi-TC support Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 05/12] net: atlantic: per-TC queue statistics Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 06/12] net: atlantic: make TCVEC2RING accept nic_cfg Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 07/12] net: atlantic: QoS implementation: max_rate Igor Russkikh
2020-05-20 17:11 ` Jakub Kicinski
2020-05-20 18:05 ` [EXT] " Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 08/12] net: atlantic: automatically downgrade the number of queues if necessary Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 09/12] net: atlantic: always use random TC-queue mapping for TX on A2 Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 10/12] net: atlantic: change the order of arguments for TC weight/credit setters Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 11/12] net: atlantic: QoS implementation: min_rate Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 12/12] net: atlantic: proper rss_ctrl1 (54c0) initialization Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200520100839.0630f025@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dbezrukov@marvell.com \
--cc=irusskikh@marvell.com \
--cc=mstarovoitov@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).