From: Igor Russkikh <irusskikh@marvell.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
"Mark Starovoytov" <mstarovoitov@marvell.com>
Subject: Re: [EXT] Re: [PATCH net-next 07/12] net: atlantic: QoS implementation: max_rate
Date: Wed, 20 May 2020 21:05:00 +0300 [thread overview]
Message-ID: <3042a968-8f74-4a46-0d81-64106206fe99@marvell.com> (raw)
In-Reply-To: <20200520101135.31aa1a13@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
> drivers/net/ethernet/aquantia/atlantic/aq_main.c: In function
> aq_ndo_setup_tc:
> drivers/net/ethernet/aquantia/atlantic/aq_main.c:369:7: warning: variable
> has_max_rate set but not used [-Wunused-but-set-variable]
> 369 | bool has_max_rate;
> | ^~~~~~~~~~~~
> drivers/net/ethernet/aquantia/atlantic/aq_main.c:368:7: warning: variable
> has_min_rate set but not used [-Wunused-but-set-variable]
> 368 | bool has_min_rate;
> | ^~~~~~~~~~~~
>
> This probably needs to moved to patch 11 where it's used.
Thanks for the review, Jakub, I don't see these on my setup, probably thats
newer gcc or different build config.
Will fix this.
Regards,
Igor
next prev parent reply other threads:[~2020-05-20 18:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 13:47 [PATCH net-next 00/12] net: atlantic: QoS implementation Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 01/12] net: atlantic: changes for multi-TC support Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 02/12] net: atlantic: move PTP TC initialization to a separate function Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 03/12] net: atlantic: changes for multi-TC support Igor Russkikh
2020-05-20 17:08 ` Jakub Kicinski
2020-05-20 21:01 ` Jakub Kicinski
2020-05-21 9:18 ` [EXT] " Mark Starovoytov
2020-05-21 19:11 ` Jakub Kicinski
2020-05-21 20:38 ` Igor Russkikh
2020-05-21 21:36 ` David Miller
2020-05-20 23:18 ` kbuild test robot
2020-05-21 2:15 ` kbuild test robot
2020-05-21 2:15 ` [RFC PATCH] net: atlantic: ptp_ring_idx() can be static kbuild test robot
2020-05-20 13:47 ` [PATCH net-next 04/12] net: atlantic: QoS implementation: multi-TC support Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 05/12] net: atlantic: per-TC queue statistics Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 06/12] net: atlantic: make TCVEC2RING accept nic_cfg Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 07/12] net: atlantic: QoS implementation: max_rate Igor Russkikh
2020-05-20 17:11 ` Jakub Kicinski
2020-05-20 18:05 ` Igor Russkikh [this message]
2020-05-20 13:47 ` [PATCH net-next 08/12] net: atlantic: automatically downgrade the number of queues if necessary Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 09/12] net: atlantic: always use random TC-queue mapping for TX on A2 Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 10/12] net: atlantic: change the order of arguments for TC weight/credit setters Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 11/12] net: atlantic: QoS implementation: min_rate Igor Russkikh
2020-05-20 13:47 ` [PATCH net-next 12/12] net: atlantic: proper rss_ctrl1 (54c0) initialization Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3042a968-8f74-4a46-0d81-64106206fe99@marvell.com \
--to=irusskikh@marvell.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=mstarovoitov@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).