From: David Miller <davem@davemloft.net>
To: kuba@kernel.org
Cc: tanhuazhong@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, salil.mehta@huawei.com,
yisen.zhuang@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature
Date: Thu, 21 May 2020 14:37:26 -0700 (PDT) [thread overview]
Message-ID: <20200521.143726.481524442371246082.davem@davemloft.net> (raw)
In-Reply-To: <20200521121707.6499ca6b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From: Jakub Kicinski <kuba@kernel.org>
Date: Thu, 21 May 2020 12:17:07 -0700
> On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote:
>> This patchset adds two new VLAN feature.
>>
>> [patch 1] adds a new dynamic VLAN mode.
>> [patch 2] adds support for 'QoS' field to PVID.
>>
>> Change log:
>> V1->V2: modifies [patch 1]'s commit log, suggested by Jakub Kicinski.
>
> I don't like the idea that FW is choosing the driver behavior in a way
> that's not observable via standard Linux APIs. This is the second time
> a feature like that posted for a driver this week, and we should
> discourage it.
Agreed, this is an unacceptable approach to driver features.
next prev parent reply other threads:[~2020-05-21 21:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 11:38 [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature Huazhong Tan
2020-05-21 11:38 ` [PATCH V2 net-next 1/2] net: hns3: adds support for dynamic VLAN mode Huazhong Tan
2020-05-21 11:38 ` [PATCH V2 net-next 2/2] net: hns3: add support for 'QoS' in port based VLAN configuration Huazhong Tan
2020-05-21 19:17 ` [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature Jakub Kicinski
2020-05-21 21:37 ` David Miller [this message]
2020-05-22 9:35 ` tanhuazhong
2020-05-27 2:31 ` tanhuazhong
2020-05-27 19:30 ` Jakub Kicinski
2020-05-28 23:46 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200521.143726.481524442371246082.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).