From: tanhuazhong <tanhuazhong@huawei.com>
To: David Miller <davem@davemloft.net>, <kuba@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<linuxarm@huawei.com>
Subject: Re: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature
Date: Wed, 27 May 2020 10:31:59 +0800 [thread overview]
Message-ID: <356be994-7cf9-e7b2-8992-46a70bc6a54b@huawei.com> (raw)
In-Reply-To: <cb427604-05ee-504c-03d0-fcce16b3cfcc@huawei.com>
On 2020/5/22 17:35, tanhuazhong wrote:
>
>
> On 2020/5/22 5:37, David Miller wrote:
>> From: Jakub Kicinski <kuba@kernel.org>
>> Date: Thu, 21 May 2020 12:17:07 -0700
>>
>>> On Thu, 21 May 2020 19:38:23 +0800 Huazhong Tan wrote:
>>>> This patchset adds two new VLAN feature.
>>>>
>>>> [patch 1] adds a new dynamic VLAN mode.
>>>> [patch 2] adds support for 'QoS' field to PVID.
>>>>
>>>> Change log:
>>>> V1->V2: modifies [patch 1]'s commit log, suggested by Jakub Kicinski.
>>>
>>> I don't like the idea that FW is choosing the driver behavior in a way
>>> that's not observable via standard Linux APIs. This is the second time
>>> a feature like that posted for a driver this week, and we should
>>> discourage it.
>>
>> Agreed, this is an unacceptable approach to driver features.
>>
>
> Hi, Jakub & David.
>
> As decribed in patch #1, there is a scenario which needs the dynamic
> mode(port VLAN filter is always disabled, andVF VLAN filter is keep
> disable until a non-zero VLAN ID being used for the function).
>
> Is this mode selection provided through "ethtool --set-priv-flags"
> more acceptable? Or is there any other better suggestion for this?
>
> Thanks.
>
Hi, Jakub & David.
For patch#1, is it acceptable adding "ethtool --get-priv-flags"
to query the VLAN. If yes, I will send a RFC for it.
Best Regards.
Thanks.
>> .
>>
next prev parent reply other threads:[~2020-05-27 2:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-21 11:38 [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature Huazhong Tan
2020-05-21 11:38 ` [PATCH V2 net-next 1/2] net: hns3: adds support for dynamic VLAN mode Huazhong Tan
2020-05-21 11:38 ` [PATCH V2 net-next 2/2] net: hns3: add support for 'QoS' in port based VLAN configuration Huazhong Tan
2020-05-21 19:17 ` [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature Jakub Kicinski
2020-05-21 21:37 ` David Miller
2020-05-22 9:35 ` tanhuazhong
2020-05-27 2:31 ` tanhuazhong [this message]
2020-05-27 19:30 ` Jakub Kicinski
2020-05-28 23:46 ` Salil Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=356be994-7cf9-e7b2-8992-46a70bc6a54b@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).