netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Igor Russkikh <irusskikh@marvell.com>,
	Mark Starovoytov <mstarovoitov@marvell.com>
Cc: <netdev@vger.kernel.org>, "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH v2 net-next 00/12] net: atlantic: QoS implementation
Date: Fri, 22 May 2020 10:58:57 -0700	[thread overview]
Message-ID: <20200522105857.759e7589@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200522081948.167-1-irusskikh@marvell.com>

On Fri, 22 May 2020 11:19:36 +0300 Igor Russkikh wrote:
> This patch series adds support for mqprio rate limiters and multi-TC:
>  * max_rate is supported on both A1 and A2;
>  * min_rate is supported on A2 only;
> 
> This is a joint work of Mark and Dmitry.
> 
> To implement this feature, a couple of rearrangements and code
> improvements were done, in areas of TC/ring management, allocation
> control, etc.
> 
> One of the problems we faced is conflicting ptp functionality, which
> consumes a whole traffic class due to hardware limitations.
> Patches below have a more detailed description on how PTP and multi-TC
> co-exist right now.
> 
> v2:
>  * accommodated review comments (-Wmissing-prototypes and
>    -Wunused-but-set-variable findings);
>  * added user notification in case of conflicting multi-TC<->PTP
>    configuration;
>  * added automatic PTP disabling, if a conflicting configuration is
>    detected;
>  * removed module param, which was used for PTP disabling in v1;
> 
> v1: https://patchwork.ozlabs.org/cover/1294380/

Acked-by: Jakub Kicinski <kuba@kernel.org>

  parent reply	other threads:[~2020-05-22 17:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  8:19 [PATCH v2 net-next 00/12] net: atlantic: QoS implementation Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 01/12] net: atlantic: changes for multi-TC support Igor Russkikh
2020-05-22 17:58   ` Jakub Kicinski
2020-05-22 19:47     ` [EXT] " Mark Starovoytov
2020-05-25 20:09       ` Jakub Kicinski
2020-05-22  8:19 ` [PATCH v2 net-next 02/12] net: atlantic: move PTP TC initialization to a separate function Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 03/12] net: atlantic: changes for multi-TC support Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 04/12] net: atlantic: QoS implementation: " Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 05/12] net: atlantic: per-TC queue statistics Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 06/12] net: atlantic: make TCVEC2RING accept nic_cfg Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 07/12] net: atlantic: QoS implementation: max_rate Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 08/12] net: atlantic: automatically downgrade the number of queues if necessary Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 09/12] net: atlantic: always use random TC-queue mapping for TX on A2 Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 10/12] net: atlantic: change the order of arguments for TC weight/credit setters Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 11/12] net: atlantic: QoS implementation: min_rate Igor Russkikh
2020-05-22  8:19 ` [PATCH v2 net-next 12/12] net: atlantic: proper rss_ctrl1 (54c0) initialization Igor Russkikh
2020-05-22 17:58 ` Jakub Kicinski [this message]
2020-05-22 21:08   ` [PATCH v2 net-next 00/12] net: atlantic: QoS implementation David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522105857.759e7589@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=irusskikh@marvell.com \
    --cc=mstarovoitov@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).