netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] crypto/chcr: error seen if CONFIG_CHELSIO_TLS_DEVICE isn't set
@ 2020-06-03  4:28 Rohit Maheshwari
  2020-06-04 22:32 ` David Miller
  0 siblings, 1 reply; 4+ messages in thread
From: Rohit Maheshwari @ 2020-06-03  4:28 UTC (permalink / raw)
  To: netdev, davem; +Cc: kuba, secdev, Rohit Maheshwari

cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which
is under CONFIG_CHELSIO_TLS_DEVICE macro.

Fixes: a3ac249a1ab5 ("cxgb4/chcr: Enable ktls settings at run time")
Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
index 0307e9c69a47..08439e215efe 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
@@ -663,6 +663,7 @@ static int uld_attach(struct adapter *adap, unsigned int uld)
 	return 0;
 }
 
+#ifdef CONFIG_CHELSIO_TLS_DEVICE
 static bool cxgb4_uld_in_use(struct adapter *adap)
 {
 	const struct tid_info *t = &adap->tids;
@@ -670,7 +671,6 @@ static bool cxgb4_uld_in_use(struct adapter *adap)
 	return (atomic_read(&t->conns_in_use) || t->stids_in_use);
 }
 
-#ifdef CONFIG_CHELSIO_TLS_DEVICE
 /* cxgb4_set_ktls_feature: request FW to enable/disable ktls settings.
  * @adap: adapter info
  * @enable: 1 to enable / 0 to disable ktls settings.
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net] crypto/chcr: error seen if CONFIG_CHELSIO_TLS_DEVICE isn't set
  2020-06-03  4:28 [PATCH net] crypto/chcr: error seen if CONFIG_CHELSIO_TLS_DEVICE isn't set Rohit Maheshwari
@ 2020-06-04 22:32 ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2020-06-04 22:32 UTC (permalink / raw)
  To: rohitm; +Cc: netdev, kuba, secdev

From: Rohit Maheshwari <rohitm@chelsio.com>
Date: Wed,  3 Jun 2020 09:58:13 +0530

> cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which
> is under CONFIG_CHELSIO_TLS_DEVICE macro.
> 
> Fixes: a3ac249a1ab5 ("cxgb4/chcr: Enable ktls settings at run time")
> Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net] crypto/chcr: error seen if CONFIG_CHELSIO_TLS_DEVICE isn't set
  2020-06-02  6:42 Rohit Maheshwari
@ 2020-06-02 18:47 ` Jakub Kicinski
  0 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2020-06-02 18:47 UTC (permalink / raw)
  To: Rohit Maheshwari; +Cc: netdev, davem, secdev

On Tue,  2 Jun 2020 12:12:13 +0530 Rohit Maheshwari wrote:
> cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which
> is under CONFIG_CHELSIO_TLS_DEVICE macro.
> 
> Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>

Please provide Fixes tags on your patches to net.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH net] crypto/chcr: error seen if CONFIG_CHELSIO_TLS_DEVICE isn't set
@ 2020-06-02  6:42 Rohit Maheshwari
  2020-06-02 18:47 ` Jakub Kicinski
  0 siblings, 1 reply; 4+ messages in thread
From: Rohit Maheshwari @ 2020-06-02  6:42 UTC (permalink / raw)
  To: netdev, davem; +Cc: secdev, Rohit Maheshwari

cxgb4_uld_in_use() is used only by cxgb4_ktls_det_feature() which
is under CONFIG_CHELSIO_TLS_DEVICE macro.

Signed-off-by: Rohit Maheshwari <rohitm@chelsio.com>
---
 drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
index 0307e9c69a47..08439e215efe 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.c
@@ -663,6 +663,7 @@ static int uld_attach(struct adapter *adap, unsigned int uld)
 	return 0;
 }
 
+#ifdef CONFIG_CHELSIO_TLS_DEVICE
 static bool cxgb4_uld_in_use(struct adapter *adap)
 {
 	const struct tid_info *t = &adap->tids;
@@ -670,7 +671,6 @@ static bool cxgb4_uld_in_use(struct adapter *adap)
 	return (atomic_read(&t->conns_in_use) || t->stids_in_use);
 }
 
-#ifdef CONFIG_CHELSIO_TLS_DEVICE
 /* cxgb4_set_ktls_feature: request FW to enable/disable ktls settings.
  * @adap: adapter info
  * @enable: 1 to enable / 0 to disable ktls settings.
-- 
2.18.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-06-04 22:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03  4:28 [PATCH net] crypto/chcr: error seen if CONFIG_CHELSIO_TLS_DEVICE isn't set Rohit Maheshwari
2020-06-04 22:32 ` David Miller
  -- strict thread matches above, loose matches on Subject: below --
2020-06-02  6:42 Rohit Maheshwari
2020-06-02 18:47 ` Jakub Kicinski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).