netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: sched: export __netdev_watchdog_up()
@ 2020-06-03 21:15 Valentin Longchamp
  2020-06-04 22:54 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Valentin Longchamp @ 2020-06-03 21:15 UTC (permalink / raw)
  To: netdev; +Cc: jiri, xiyou.wangcong, jhs, Valentin Longchamp, stable

Since the quiesce/activate rework, __netdev_watchdog_up() is directly
called in the ucc_geth driver.

Unfortunately, this function is not available for modules and thus
ucc_geth cannot be built as a module anymore. Fix it by exporting
__netdev_watchdog_up().

Since the commit introducing the regression was backported to stable
branches, this one should ideally be as well.

Fixes: 79dde73cf9bc ("net/ethernet/freescale: rework quiesce/activate for ucc_geth")
Cc: <stable@vger.kernel.org>
Signed-off-by: Valentin Longchamp <valentin@longchamp.me>
---
 net/sched/sch_generic.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 2efd5b61acef..f1816516f638 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -464,6 +464,7 @@ void __netdev_watchdog_up(struct net_device *dev)
 			dev_hold(dev);
 	}
 }
+EXPORT_SYMBOL(__netdev_watchdog_up);
 
 static void dev_watchdog_up(struct net_device *dev)
 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: sched: export __netdev_watchdog_up()
  2020-06-03 21:15 [PATCH] net: sched: export __netdev_watchdog_up() Valentin Longchamp
@ 2020-06-04 22:54 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-06-04 22:54 UTC (permalink / raw)
  To: valentin; +Cc: netdev, jiri, xiyou.wangcong, jhs, stable

From: Valentin Longchamp <valentin@longchamp.me>
Date: Wed,  3 Jun 2020 23:15:27 +0200

> @@ -464,6 +464,7 @@ void __netdev_watchdog_up(struct net_device *dev)
>  			dev_hold(dev);
>  	}
>  }
> +EXPORT_SYMBOL(__netdev_watchdog_up);

Please use EXPORT_SYMBOL_GPL(), thank you.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-04 22:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-03 21:15 [PATCH] net: sched: export __netdev_watchdog_up() Valentin Longchamp
2020-06-04 22:54 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).