netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: David Miller <davem@davemloft.net>
Cc: stephen@networkplumber.org, o.rempel@pengutronix.de,
	andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
	kuba@kernel.org, corbet@lwn.net, mkubecek@suse.cz,
	linville@tuxdriver.com, david@protonic.nl, kernel@pengutronix.de,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux@armlinux.org.uk, mkl@pengutronix.de, marex@denx.de,
	christian.herber@nxp.com, amitc@mellanox.com, petrm@mellanox.com
Subject: Re: [PATCH ethtool v1] netlink: add master/slave configuration support
Date: Tue, 9 Jun 2020 12:49:48 -0700	[thread overview]
Message-ID: <202006091244.C8B5F9525@keescook> (raw)
In-Reply-To: <20200609.123437.1057990370119930723.davem@davemloft.net>

On Tue, Jun 09, 2020 at 12:34:37PM -0700, David Miller wrote:
> From: Kees Cook <keescook@chromium.org>
> Date: Tue, 9 Jun 2020 12:29:54 -0700
> 
> > Given what I've seen from other communities and what I know of the kernel
> > community, I don't think we're going to get consensus on some massive
> > global search/replace any time soon. However, I think we can get started
> > on making this change with just stopping further introductions. (I view
> > this like any other treewide change: stop new badness from getting
> > added, and chip away as old ones as we can until it's all gone.)
> 
> The terminology being suggested by these changes matches what is used
> in the standards and literature.
> 
> Inventing something creates confusion for those who are familiar with
> these pieces of technology already, and those who are not who are
> reading about it elsewhere.
> 
> Both groups will be terminally confused if we use different words.
> 
> For such pain, there should be agood reason.  I don't accept Stephen's
> quoted standards bodies "efforts" as a legitimate reason, or evidence
> of such, as it has a lot of holes in it as Edward pointed out.  I
> found the Orwell references to be quite ironic actually.

Okay, for now, how about:

- If we're dealing with an existing spec, match the language.
- If we're dealing with a new spec, ask the authors to fix their language.
- If a new version of a spec has updated its language, adjust the kernel's.
- If we're doing with something "internal" to the kernel (including UAPI),
  stop adding new instances.

-- 
Kees Cook

  reply	other threads:[~2020-06-09 19:49 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-26  9:10 [PATCH ethtool v1] netlink: add master/slave configuration support Oleksij Rempel
2020-05-26 12:41 ` Michal Kubecek
2020-05-27 10:26   ` Oleksij Rempel
2020-06-07 22:30 ` Stephen Hemminger
2020-06-07 23:45   ` David Miller
2020-06-09 17:19     ` Stephen Hemminger
2020-06-09 18:30       ` Andrew Lunn
2020-06-09 18:36       ` David Miller
2020-06-09 19:29         ` Kees Cook
2020-06-09 19:34           ` David Miller
2020-06-09 19:49             ` Kees Cook [this message]
2020-06-09 20:05               ` David Miller
2020-06-09 20:29                 ` Kees Cook
2020-06-09 20:53                   ` Michal Kubecek
2020-06-09 21:34                     ` Kees Cook
2020-06-09 19:30         ` Williams, Dan J
2020-06-09 19:38           ` David Miller
2020-06-09 21:48             ` Dan Williams
2020-06-10  6:07               ` Oleksij Rempel
2020-06-09 18:46       ` Edward Cree
2020-06-09 20:31       ` Michal Kubecek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202006091244.C8B5F9525@keescook \
    --to=keescook@chromium.org \
    --cc=amitc@mellanox.com \
    --cc=andrew@lunn.ch \
    --cc=christian.herber@nxp.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=david@protonic.nl \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linville@tuxdriver.com \
    --cc=marex@denx.de \
    --cc=mkl@pengutronix.de \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=petrm@mellanox.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).