* [PATCH] net: phy: mscc: fix ptr_ret.cocci warnings
[not found] <202006260959.QkSmCdSE%lkp@intel.com>
@ 2020-06-26 1:05 ` kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2020-06-26 1:05 UTC (permalink / raw)
To: Antoine Tenart
Cc: kbuild-all, Quentin Schulz, Andrew Lunn, Florian Fainelli,
Heiner Kallweit, Russell King, Jakub Kicinski, netdev,
linux-kernel
From: kernel test robot <lkp@intel.com>
drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: 7d272e63e097 ("net: phy: mscc: timestamping and PHC support")
CC: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 3f9437c6234d95d96967f1b438a4fb71b6be254d
commit: 7d272e63e0979d38a6256108adbe462d621c26c5 [3775/3988] net: phy: mscc: timestamping and PHC support
mscc_ptp.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/net/phy/mscc/mscc_ptp.c
+++ b/drivers/net/phy/mscc/mscc_ptp.c
@@ -1493,10 +1493,7 @@ static int __vsc8584_init_ptp(struct phy
vsc8531->ptp->ptp_clock = ptp_clock_register(&vsc8531->ptp->caps,
&phydev->mdio.dev);
- if (IS_ERR(vsc8531->ptp->ptp_clock))
- return PTR_ERR(vsc8531->ptp->ptp_clock);
-
- return 0;
+ return PTR_ERR_OR_ZERO(vsc8531->ptp->ptp_clock);
}
void vsc8584_config_ts_intr(struct phy_device *phydev)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: phy: mscc: fix ptr_ret.cocci warnings
2020-07-09 16:06 ` kernel test robot
@ 2020-07-09 20:10 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2020-07-09 20:10 UTC (permalink / raw)
To: lkp
Cc: antoine.tenart, kbuild-all, quentin.schulz, andrew, f.fainelli,
hkallweit1, linux, kuba, netdev, linux-kernel
From: kernel test robot <lkp@intel.com>
Date: Fri, 10 Jul 2020 00:06:18 +0800
> From: kernel test robot <lkp@intel.com>
>
> drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used
>
>
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
>
> Fixes: 7d272e63e097 ("net: phy: mscc: timestamping and PHC support")
> CC: Antoine Tenart <antoine.tenart@bootlin.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net: phy: mscc: fix ptr_ret.cocci warnings
[not found] <202007100043.AqyWtI2n%lkp@intel.com>
@ 2020-07-09 16:06 ` kernel test robot
2020-07-09 20:10 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2020-07-09 16:06 UTC (permalink / raw)
To: Antoine Tenart
Cc: kbuild-all, Quentin Schulz, Andrew Lunn, Florian Fainelli,
Heiner Kallweit, Russell King, Jakub Kicinski, netdev,
linux-kernel
From: kernel test robot <lkp@intel.com>
drivers/net/phy/mscc/mscc_ptp.c:1496:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
Generated by: scripts/coccinelle/api/ptr_ret.cocci
Fixes: 7d272e63e097 ("net: phy: mscc: timestamping and PHC support")
CC: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: b966b5cf71790478be7726593d011cb085a97a94
commit: 7d272e63e0979d38a6256108adbe462d621c26c5 [2625/6900] net: phy: mscc: timestamping and PHC support
mscc_ptp.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
--- a/drivers/net/phy/mscc/mscc_ptp.c
+++ b/drivers/net/phy/mscc/mscc_ptp.c
@@ -1493,10 +1493,7 @@ static int __vsc8584_init_ptp(struct phy
vsc8531->ptp->ptp_clock = ptp_clock_register(&vsc8531->ptp->caps,
&phydev->mdio.dev);
- if (IS_ERR(vsc8531->ptp->ptp_clock))
- return PTR_ERR(vsc8531->ptp->ptp_clock);
-
- return 0;
+ return PTR_ERR_OR_ZERO(vsc8531->ptp->ptp_clock);
}
void vsc8584_config_ts_intr(struct phy_device *phydev)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-09 20:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <202006260959.QkSmCdSE%lkp@intel.com>
2020-06-26 1:05 ` [PATCH] net: phy: mscc: fix ptr_ret.cocci warnings kernel test robot
[not found] <202007100043.AqyWtI2n%lkp@intel.com>
2020-07-09 16:06 ` kernel test robot
2020-07-09 20:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).