From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 4/8] bnxt_en: Fill HW RSS table from the RSS logical indirection table.
Date: Mon, 29 Jun 2020 16:58:11 -0700 [thread overview]
Message-ID: <20200629165811.4ae9e0f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1593412464-503-5-git-send-email-michael.chan@broadcom.com>
On Mon, 29 Jun 2020 02:34:20 -0400 Michael Chan wrote:
> Now that we have the logical table, we can fill the HW RSS table
> using the logical table's entries and converting them to the HW
> specific format. Re-initialize the logical table to standard
> distribution if the number of RX rings changes during ring reservation.
>
> Signed-off-by: Michael Chan <michael.chan@broadcom.com>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 89 ++++++++++++++++++-------------
> 1 file changed, 53 insertions(+), 36 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 7bf843d..87d37dc 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -4882,9 +4882,52 @@ int bnxt_get_nr_rss_ctxs(struct bnxt *bp, int rx_rings)
> return 1;
> }
>
> +static void __bnxt_fill_hw_rss_tbl(struct bnxt *bp, struct bnxt_vnic_info *vnic)
> +{
> + bool no_rss = !(vnic->flags & BNXT_VNIC_RSS_FLAG);
> + u16 i, j;
> +
> + /* Fill the RSS indirection table with ring group ids */
> + for (i = 0, j = 0; i < HW_HASH_INDEX_SIZE; i++) {
> + if (!no_rss)
> + j = bp->rss_indir_tbl[i];
> + vnic->rss_table[i] = cpu_to_le16(vnic->fw_grp_ids[j]);
> + }
> +}
> +
> +static void __bnxt_fill_hw_rss_tbl_p5(struct bnxt *bp,
> + struct bnxt_vnic_info *vnic)
> +{
> + __le16 *ring_tbl = vnic->rss_table;
> + struct bnxt_rx_ring_info *rxr;
> + u16 tbl_size, i;
> +
> + tbl_size = (bp->rx_nr_rings + BNXT_RSS_TABLE_ENTRIES_P5 - 1) &
> + ~(BNXT_RSS_TABLE_ENTRIES_P5 - 1);
nit: DIV_ROUND_UP() ?
> + for (i = 0; i < tbl_size; i++) {
> + u16 ring_id, j;
> +
> + j = bp->rss_indir_tbl[i];
> + rxr = &bp->rx_ring[j];
> +
> + ring_id = rxr->rx_ring_struct.fw_ring_id;
> + *ring_tbl++ = cpu_to_le16(ring_id);
> + ring_id = bnxt_cp_ring_for_rx(bp, rxr);
> + *ring_tbl++ = cpu_to_le16(ring_id);
> + }
> +}
> +
> @@ -8252,6 +8267,8 @@ int bnxt_reserve_rings(struct bnxt *bp, bool irq_re_init)
> rc = bnxt_init_int_mode(bp);
> bnxt_ulp_irq_restart(bp, rc);
> }
if (!netif_is_rxfh_configured(nn->dp.netdev))
> + bnxt_set_dflt_rss_indir_tbl(bp);
> +
> if (rc) {
> netdev_err(bp->dev, "ring reservation/IRQ init failure rc: %d\n", rc);
> return rc;
next prev parent reply other threads:[~2020-06-29 23:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 6:34 [PATCH net-next 0/8] bnxt_en: Driver update for net-next Michael Chan
2020-06-29 6:34 ` [PATCH net-next 1/8] bnxt_en: Set up the chip specific RSS table size Michael Chan
2020-06-29 6:34 ` [PATCH net-next 2/8] bnxt_en: Add logical RSS indirection table structure Michael Chan
2020-06-29 23:53 ` Jakub Kicinski
2020-06-29 6:34 ` [PATCH net-next 3/8] bnxt_en: Add helper function to return the number of RSS contexts Michael Chan
2020-06-29 6:34 ` [PATCH net-next 4/8] bnxt_en: Fill HW RSS table from the RSS logical indirection table Michael Chan
2020-06-29 23:58 ` Jakub Kicinski [this message]
2020-06-30 0:42 ` Michael Chan
2020-06-29 6:34 ` [PATCH net-next 5/8] bnxt_en: Return correct RSS indirection table entries to ethtool -x Michael Chan
2020-06-29 6:34 ` [PATCH net-next 6/8] bnxt_en: Implement ethtool -X to set indirection table Michael Chan
2020-06-30 0:06 ` Jakub Kicinski
2020-06-30 0:38 ` Michael Chan
2020-06-30 19:05 ` Jakub Kicinski
2020-06-30 19:42 ` Michael Chan
2020-06-29 6:34 ` [PATCH net-next 7/8] bnxt_en: clean up VLAN feature bit handling Michael Chan
2020-06-29 6:34 ` [PATCH net-next 8/8] bnxt_en: allow firmware to disable VLAN offloads Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629165811.4ae9e0f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).