* [PATCH net] cxgb4: fix all-mask IP address comparison
@ 2020-07-08 21:44 Rahul Lakkireddy
2020-07-08 22:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Lakkireddy @ 2020-07-08 21:44 UTC (permalink / raw)
To: netdev; +Cc: davem, pavel, nirranjan, vishal, dt
Convert all-mask IP address to Big Endian, instead, for comparison.
Fixes: f286dd8eaad5 ("cxgb4: use correct type for all-mask IP address comparison")
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
---
drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
index 7a7f61a8cdf4..d02d346629b3 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_filter.c
@@ -1112,16 +1112,16 @@ static bool is_addr_all_mask(u8 *ipmask, int family)
struct in_addr *addr;
addr = (struct in_addr *)ipmask;
- if (ntohl(addr->s_addr) == 0xffffffff)
+ if (addr->s_addr == htonl(0xffffffff))
return true;
} else if (family == AF_INET6) {
struct in6_addr *addr6;
addr6 = (struct in6_addr *)ipmask;
- if (ntohl(addr6->s6_addr32[0]) == 0xffffffff &&
- ntohl(addr6->s6_addr32[1]) == 0xffffffff &&
- ntohl(addr6->s6_addr32[2]) == 0xffffffff &&
- ntohl(addr6->s6_addr32[3]) == 0xffffffff)
+ if (addr6->s6_addr32[0] == htonl(0xffffffff) &&
+ addr6->s6_addr32[1] == htonl(0xffffffff) &&
+ addr6->s6_addr32[2] == htonl(0xffffffff) &&
+ addr6->s6_addr32[3] == htonl(0xffffffff))
return true;
}
return false;
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] cxgb4: fix all-mask IP address comparison
2020-07-08 21:44 [PATCH net] cxgb4: fix all-mask IP address comparison Rahul Lakkireddy
@ 2020-07-08 22:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-07-08 22:43 UTC (permalink / raw)
To: rahul.lakkireddy; +Cc: netdev, pavel, nirranjan, vishal, dt
From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Date: Thu, 9 Jul 2020 03:14:27 +0530
> Convert all-mask IP address to Big Endian, instead, for comparison.
>
> Fixes: f286dd8eaad5 ("cxgb4: use correct type for all-mask IP address comparison")
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-08 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-08 21:44 [PATCH net] cxgb4: fix all-mask IP address comparison Rahul Lakkireddy
2020-07-08 22:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).