netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: enetc: use eth_broadcast_addr() to assign broadcast
@ 2020-07-09  6:48 Xu Wang
  2020-07-09 19:33 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Xu Wang @ 2020-07-09  6:48 UTC (permalink / raw)
  To: colyli, claudiu.manoil, davem, kuba, netdev; +Cc: linux-kernel, Xu Wang

This patch is to use eth_broadcast_addr() to assign broadcast address
insetad of memset().

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 drivers/net/ethernet/freescale/enetc/enetc_qos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/enetc/enetc_qos.c b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
index fd3df19eaa32..6fc0c275306f 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc_qos.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc_qos.c
@@ -487,7 +487,7 @@ static int enetc_streamid_hw_set(struct enetc_ndev_priv *priv,
 
 	cbd.addr[0] = lower_32_bits(dma);
 	cbd.addr[1] = upper_32_bits(dma);
-	memset(si_data->dmac, 0xff, ETH_ALEN);
+	eth_broadcast_addr(si_data->dmac);
 	si_data->vid_vidm_tg =
 		cpu_to_le16(ENETC_CBDR_SID_VID_MASK
 			    + ((0x3 << 14) | ENETC_CBDR_SID_VIDM));
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] net: enetc: use eth_broadcast_addr() to assign broadcast
  2020-07-09  6:48 [PATCH] net: enetc: use eth_broadcast_addr() to assign broadcast Xu Wang
@ 2020-07-09 19:33 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-07-09 19:33 UTC (permalink / raw)
  To: vulab; +Cc: colyli, claudiu.manoil, kuba, netdev, linux-kernel

From: Xu Wang <vulab@iscas.ac.cn>
Date: Thu,  9 Jul 2020 06:48:55 +0000

> This patch is to use eth_broadcast_addr() to assign broadcast address
> insetad of memset().
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Applied to net-next, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-09 19:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09  6:48 [PATCH] net: enetc: use eth_broadcast_addr() to assign broadcast Xu Wang
2020-07-09 19:33 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).