From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>,
Edwin Peer <edwin.peer@broadcom.com>,
emil.s.tantilov@intel.com, alexander.h.duyck@linux.intel.com,
jeffrey.t.kirsher@intel.com, Tariq Toukan <tariqt@mellanox.com>,
mkubecek@suse.cz
Subject: Re: [PATCH net-next v2 09/10] bnxt: convert to new udp_tunnel_nic infra
Date: Thu, 9 Jul 2020 13:56:05 -0700 [thread overview]
Message-ID: <20200709135605.6ad96b88@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CACKFLikN6utQT2eXKtnhZFMYxt8Tem-An=6cxX6nXgPiO+k5UQ@mail.gmail.com>
On Wed, 8 Jul 2020 22:27:13 -0700 Michael Chan wrote:
> On Wed, Jul 8, 2020 at 6:18 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > Convert to new infra, taking advantage of sleeping in callbacks.
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > ---
> > drivers/net/ethernet/broadcom/bnxt/bnxt.c | 133 ++++++----------------
> > drivers/net/ethernet/broadcom/bnxt/bnxt.h | 6 -
> > 2 files changed, 34 insertions(+), 105 deletions(-)
> >
>
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> > index 78e2fd63ac3d..352a56a18916 100644
> > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> > @@ -1752,10 +1752,8 @@ struct bnxt {
> > #define BNXT_FW_MAJ(bp) ((bp)->fw_ver_code >> 48)
> >
> > __be16 vxlan_port;
>
> We can also do away with vxlan_port and nge_port, now that we no
> longer need to pass the port from NDO to workqueue. We just need to
> initialize the 2 firmware tunnel IDs to INVALID_HW_RING_ID before use
> and after free. But it is ok the way you have it too.
Seems like I need to send a v3 anyway - the only reason I kept them is
to know if bnxt_hwrm_free_tunnel_ports() has to issue its commands or
not.
Are you suggesting I just add a flag that'd say "tunnel in use" instead
of holding onto the ports? Or free unconditionally?
next prev parent reply other threads:[~2020-07-09 20:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 1:18 [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 01/10] debugfs: make sure we can remove u32_array files cleanly Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 02/10] udp_tunnel: re-number the offload tunnel types Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 03/10] udp_tunnel: add central NIC RX port offload infrastructure Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 04/10] ethtool: add tunnel info interface Jakub Kicinski
2020-07-09 14:19 ` kernel test robot
2020-07-09 1:18 ` [PATCH net-next v2 05/10] netdevsim: add UDP tunnel port offload support Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 06/10] selftests: net: add a test for UDP tunnel info infra Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 07/10] ixgbe: don't clear UDP tunnel ports when RXCSUM is disabled Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 08/10] ixgbe: convert to new udp_tunnel_nic infra Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 09/10] bnxt: " Jakub Kicinski
2020-07-09 5:27 ` Michael Chan
2020-07-09 20:56 ` Jakub Kicinski [this message]
2020-07-09 21:24 ` Michael Chan
2020-07-09 1:18 ` [PATCH net-next v2 10/10] mlx4: " Jakub Kicinski
2020-07-09 13:58 ` Tariq Toukan
2020-07-09 17:08 ` Tariq Toukan
2020-07-09 20:56 ` Jakub Kicinski
2020-07-09 18:23 ` [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure David Miller
2020-07-09 20:51 ` Jakub Kicinski
2020-07-10 2:33 ` Tom Herbert
2020-07-10 3:02 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709135605.6ad96b88@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edwin.peer@broadcom.com \
--cc=emil.s.tantilov@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).