From: Jakub Kicinski <kuba@kernel.org>
To: Tom Herbert <tom@herbertland.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>,
Michael Chan <michael.chan@broadcom.com>,
edwin.peer@broadcom.com, emil.s.tantilov@intel.com,
alexander.h.duyck@linux.intel.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Tariq Toukan <tariqt@mellanox.com>,
Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure
Date: Thu, 9 Jul 2020 20:02:45 -0700 [thread overview]
Message-ID: <20200709200245.6644aa56@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CALx6S34JePNX62=rPq5aTW6W_tpPwSeseGcq13iAaJ9Y53QTiQ@mail.gmail.com>
On Thu, 9 Jul 2020 19:33:11 -0700 Tom Herbert wrote:
> The patch set looks good for its purpose, but, sorry, I can't resist
> another round of complaining about vendors that continue to develop
> protocol specific offloads instead of moving to protocol agnostic
> generic offloads.
I agree with all your points. I hope that the improvements in visibility
into NIC capabilities and state will not encourage vendors to provide
more protocol specific offloads.
Out-of-tree drivers for the last few generations of HW already have
the capability to query or configure the RSS over inner fields, so
that would just catch upstream up with the existing hacks.
I hope that building more opinionated logic as an explicit device driver
interface, rather than expecting drivers to peer directly into the state
of the stack will also help us shape the offloads. (Perhaps we would
have caught that folks are using the UDP ports for TX parsing if we
started this way.) Whether my work is misguided or I'm going about it
in a wrong way.. hard for me to tell :S
Oh, and I don't currently work for a vendor, perhaps that'd help you
trust my intentions here ;)
prev parent reply other threads:[~2020-07-10 3:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 1:18 [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 01/10] debugfs: make sure we can remove u32_array files cleanly Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 02/10] udp_tunnel: re-number the offload tunnel types Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 03/10] udp_tunnel: add central NIC RX port offload infrastructure Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 04/10] ethtool: add tunnel info interface Jakub Kicinski
2020-07-09 14:19 ` kernel test robot
2020-07-09 1:18 ` [PATCH net-next v2 05/10] netdevsim: add UDP tunnel port offload support Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 06/10] selftests: net: add a test for UDP tunnel info infra Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 07/10] ixgbe: don't clear UDP tunnel ports when RXCSUM is disabled Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 08/10] ixgbe: convert to new udp_tunnel_nic infra Jakub Kicinski
2020-07-09 1:18 ` [PATCH net-next v2 09/10] bnxt: " Jakub Kicinski
2020-07-09 5:27 ` Michael Chan
2020-07-09 20:56 ` Jakub Kicinski
2020-07-09 21:24 ` Michael Chan
2020-07-09 1:18 ` [PATCH net-next v2 10/10] mlx4: " Jakub Kicinski
2020-07-09 13:58 ` Tariq Toukan
2020-07-09 17:08 ` Tariq Toukan
2020-07-09 20:56 ` Jakub Kicinski
2020-07-09 18:23 ` [PATCH net-next v2 00/10] udp_tunnel: add NIC RX port offload infrastructure David Miller
2020-07-09 20:51 ` Jakub Kicinski
2020-07-10 2:33 ` Tom Herbert
2020-07-10 3:02 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709200245.6644aa56@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edwin.peer@broadcom.com \
--cc=emil.s.tantilov@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=michael.chan@broadcom.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=tariqt@mellanox.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).