[PATCH 2/4] cdc_ether: use dev->intf to get interface information

[PATCH 2/4] cdc_ether: use dev->intf to get interface information

[Wxcafé]

This makes the function available to other drivers, like cdn_ncm.

Signed-off-by: Miguel Rodríguez Pérez <miguel@det.uvigo.gal>
---
 drivers/net/usb/cdc_ether.c | 3 ++-
 include/linux/usb/usbnet.h  | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/usb/cdc_ether.c b/drivers/net/usb/cdc_ether.c
index 2afe258e3648..8c1d61c2cbac 100644
--- a/drivers/net/usb/cdc_ether.c
+++ b/drivers/net/usb/cdc_ether.c
@@ -63,7 +63,7 @@ static const u8 mbm_guid[16] = {
 	0xa6, 0x07, 0xc0, 0xff, 0xcb, 0x7e, 0x39, 0x2a,
 };
 
-static void usbnet_cdc_update_filter(struct usbnet *dev)
+void usbnet_cdc_update_filter(struct usbnet *dev)
 {
 	struct net_device	*net = dev->net;
 
@@ -90,6 +90,7 @@ static void usbnet_cdc_update_filter(struct usbnet *dev)
 			USB_CTRL_SET_TIMEOUT
 		);
 }
+EXPORT_SYMBOL_GPL(usbnet_cdc_update_filter);
 
 /* probes control interface, claims data interface, collects the bulk
  * endpoints, activates data interface (if needed), maybe sets MTU.
diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h
index b0bff3083278..33e7803b85af 100644
--- a/include/linux/usb/usbnet.h
+++ b/include/linux/usb/usbnet.h
@@ -286,4 +286,5 @@ extern void usbnet_update_max_qlen(struct usbnet *dev);
 extern void usbnet_get_stats64(struct net_device *dev,
 			       struct rtnl_link_stats64 *stats);
 
+extern void usbnet_cdc_update_filter(struct usbnet *);
 #endif /* __LINUX_USB_USBNET_H */
-- 
2.27.0

-- 
Wxcafé <wxcafe@wxcafe.net>

[PATCH 2/4] cdc_ether: export usbnet_cdc_update_filter

[Wxcafé]

Fixed the title, sorry

-- 
Wxcafé <wxcafe@wxcafe.net>

On Tue, 2020-07-14 at 21:25 -0400, Wxcafé wrote:
> This makes the function available to other drivers, like cdn_ncm.
> 
> Signed-off-by: Miguel Rodríguez Pérez <miguel@det.uvigo.gal>
> ---
>  drivers/net/usb/cdc_ether.c | 3 ++-
>  include/linux/usb/usbnet.h  | 1 +
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/cdc_ether.c
> b/drivers/net/usb/cdc_ether.c
> index 2afe258e3648..8c1d61c2cbac 100644
> --- a/drivers/net/usb/cdc_ether.c
> +++ b/drivers/net/usb/cdc_ether.c
> @@ -63,7 +63,7 @@ static const u8 mbm_guid[16] = {
>  	0xa6, 0x07, 0xc0, 0xff, 0xcb, 0x7e, 0x39, 0x2a,
>  };
>  
> -static void usbnet_cdc_update_filter(struct usbnet *dev)
> +void usbnet_cdc_update_filter(struct usbnet *dev)
>  {
>  	struct net_device	*net = dev->net;
>  
> @@ -90,6 +90,7 @@ static void usbnet_cdc_update_filter(struct usbnet
> *dev)
>  			USB_CTRL_SET_TIMEOUT
>  		);
>  }
> +EXPORT_SYMBOL_GPL(usbnet_cdc_update_filter);
>  
>  /* probes control interface, claims data interface, collects the
> bulk
>   * endpoints, activates data interface (if needed), maybe sets MTU.
> diff --git a/include/linux/usb/usbnet.h b/include/linux/usb/usbnet.h
> index b0bff3083278..33e7803b85af 100644
> --- a/include/linux/usb/usbnet.h
> +++ b/include/linux/usb/usbnet.h
> @@ -286,4 +286,5 @@ extern void usbnet_update_max_qlen(struct usbnet
> *dev);
>  extern void usbnet_get_stats64(struct net_device *dev,
>  			       struct rtnl_link_stats64 *stats);
>  
> +extern void usbnet_cdc_update_filter(struct usbnet *);
>  #endif /* __LINUX_USB_USBNET_H */
> -- 
> 2.27.0
> 

Re: [PATCH 2/4] cdc_ether: use dev->intf to get interface information

[Greg KH]

On Tue, Jul 14, 2020 at 09:25:13PM -0400, Wxcafé wrote:
> This makes the function available to other drivers, like cdn_ncm.
> 
> Signed-off-by: Miguel Rodríguez Pérez <miguel@det.uvigo.gal>

The subject line does not match the patch :(

Also, when sending on patches from others, you too have to sign off on
it.

And, set the proper From: line in the body of the email, like the
documentation says to do, otherwise you loose the original authorship
information.

thanks,

greg k-h

Re: [PATCH 2/4] cdc_ether: export usbnet_cdc_update_filter

[Greg KH]

On Tue, Jul 14, 2020 at 09:32:12PM -0400, Wxcafé wrote:
> Fixed the title, sorry

That did nothing for us, you have to send a new patch series, we can not
hand-edit each patch for stuff like this :(