[PATCH iproute2] tc/m_estimator: Print proper value for estimator interval in raw.

[PATCH iproute2] tc/m_estimator: Print proper value for estimator interval in raw.

[Jamie Gloudon]

While looking at the estimator code, I noticed an incorrect interval
number printed in raw for the handles. This patch fixes the formatting.

Before patch:

root@bytecenter.fr:~# tc -r filter add dev eth0 ingress estimator
250ms 999ms matchall action police avrate 12mbit conform-exceed drop
[estimator i=4294967294 e=2]

After patch:

root@bytecenter.fr:~# tc -r filter add dev eth0 ingress estimator
250ms 999ms matchall action police avrate 12mbit conform-exceed drop
[estimator i=-2 e=2]

Signed-off-by: Jamie Gloudon <jamie.gloudon@gmx.fr>
---
 tc/m_estimator.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tc/m_estimator.c b/tc/m_estimator.c
index ef62e1bb..b5f4c860 100644
--- a/tc/m_estimator.c
+++ b/tc/m_estimator.c
@@ -57,7 +57,7 @@ int parse_estimator(int *p_argc, char ***p_argv, struct tc_estimator *est)
 		return -1;
 	}
 	if (show_raw)
-		fprintf(stderr, "[estimator i=%u e=%u]\n", est->interval, est->ewma_log);
+		fprintf(stderr, "[estimator i=%hhd e=%u]\n", est->interval, est->ewma_log);
 	*p_argc = argc;
 	*p_argv = argv;
 	return 0;
--
2.17.5

Re: [PATCH iproute2] tc/m_estimator: Print proper value for estimator interval in raw.

[Stephen Hemminger]

On Fri, 17 Jul 2020 11:05:30 -0400
Jamie Gloudon <jamie.gloudon@gmx.fr> wrote:

> While looking at the estimator code, I noticed an incorrect interval
> number printed in raw for the handles. This patch fixes the formatting.
> 
> Before patch:
> 
> root@bytecenter.fr:~# tc -r filter add dev eth0 ingress estimator
> 250ms 999ms matchall action police avrate 12mbit conform-exceed drop
> [estimator i=4294967294 e=2]
> 
> After patch:
> 
> root@bytecenter.fr:~# tc -r filter add dev eth0 ingress estimator
> 250ms 999ms matchall action police avrate 12mbit conform-exceed drop
> [estimator i=-2 e=2]
> 
> Signed-off-by: Jamie Gloudon <jamie.gloudon@gmx.fr>
> ---
>  tc/m_estimator.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tc/m_estimator.c b/tc/m_estimator.c
> index ef62e1bb..b5f4c860 100644
> --- a/tc/m_estimator.c
> +++ b/tc/m_estimator.c
> @@ -57,7 +57,7 @@ int parse_estimator(int *p_argc, char ***p_argv, struct tc_estimator *est)
>  		return -1;
>  	}
>  	if (show_raw)
> -		fprintf(stderr, "[estimator i=%u e=%u]\n", est->interval, est->ewma_log);
> +		fprintf(stderr, "[estimator i=%hhd e=%u]\n", est->interval, est->ewma_log);
>  	*p_argc = argc;
>  	*p_argv = argv;
>  	return 0;
> --
> 2.17.5
> 

Looks ok to me. Could you update estimator to print JSON as well?