netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH for v5.9] sctp: Replace HTTP links with HTTPS ones
@ 2020-07-19 20:26 Alexander A. Klimov
  2020-07-20 13:11 ` Marcelo Ricardo Leitner
  0 siblings, 1 reply; 2+ messages in thread
From: Alexander A. Klimov @ 2020-07-19 20:26 UTC (permalink / raw)
  To: vyasevich, nhorman, marcelo.leitner, davem, kuba, corbet,
	linux-sctp, netdev, linux-doc, linux-kernel
  Cc: Alexander A. Klimov

Rationale:
Reduces attack surface on kernel devs opening the links for MITM
as HTTPS traffic is much harder to manipulate.

Deterministic algorithm:
For each file:
  If not .svg:
    For each line:
      If doesn't contain `\bxmlns\b`:
        For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
            If both the HTTP and HTTPS versions
            return 200 OK and serve the same content:
              Replace HTTP with HTTPS.

Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
---
 Continuing my work started at 93431e0607e5.
 See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master
 (Actually letting a shell for loop submit all this stuff for me.)

 If there are any URLs to be removed completely
 or at least not (just) HTTPSified:
 Just clearly say so and I'll *undo my change*.
 See also: https://lkml.org/lkml/2020/6/27/64

 If there are any valid, but yet not changed URLs:
 See: https://lkml.org/lkml/2020/6/26/837

 If you apply the patch, please let me know.

 Sorry again to all maintainers who complained about subject lines.
 Now I realized that you want an actually perfect prefixes,
 not just subsystem ones.
 I tried my best...
 And yes, *I could* (at least half-)automate it.
 Impossible is nothing! :)


 Documentation/networking/sctp.rst | 4 ++--
 net/sctp/Kconfig                  | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/networking/sctp.rst b/Documentation/networking/sctp.rst
index 9f4d9c8a925b..e2b9f4d9a8a2 100644
--- a/Documentation/networking/sctp.rst
+++ b/Documentation/networking/sctp.rst
@@ -15,8 +15,8 @@ developed the SCTP protocol and later handed the protocol over to the
 Transport Area (TSVWG) working group for the continued evolvement of SCTP as a
 general purpose transport.
 
-See the IETF website (http://www.ietf.org) for further documents on SCTP.
-See http://www.ietf.org/rfc/rfc2960.txt
+See the IETF website (https://www.ietf.org) for further documents on SCTP.
+See https://www.ietf.org/rfc/rfc2960.txt
 
 The initial project goal is to create an Linux kernel reference implementation
 of SCTP that is RFC 2960 compliant and provides an programming interface
diff --git a/net/sctp/Kconfig b/net/sctp/Kconfig
index 39d7fa9569f8..0d4ac89ad695 100644
--- a/net/sctp/Kconfig
+++ b/net/sctp/Kconfig
@@ -14,7 +14,7 @@ menuconfig IP_SCTP
 	help
 	  Stream Control Transmission Protocol
 
-	  From RFC 2960 <http://www.ietf.org/rfc/rfc2960.txt>.
+	  From RFC 2960 <https://www.ietf.org/rfc/rfc2960.txt>.
 
 	  "SCTP is a reliable transport protocol operating on top of a
 	  connectionless packet network such as IP.  It offers the following
-- 
2.27.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH for v5.9] sctp: Replace HTTP links with HTTPS ones
  2020-07-19 20:26 [PATCH for v5.9] sctp: Replace HTTP links with HTTPS ones Alexander A. Klimov
@ 2020-07-20 13:11 ` Marcelo Ricardo Leitner
  0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Ricardo Leitner @ 2020-07-20 13:11 UTC (permalink / raw)
  To: Alexander A. Klimov
  Cc: vyasevich, nhorman, davem, kuba, corbet, linux-sctp, netdev,
	linux-doc, linux-kernel

On Sun, Jul 19, 2020 at 10:26:44PM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>   If not .svg:
>     For each line:
>       If doesn't contain `\bxmlns\b`:
>         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>             If both the HTTP and HTTPS versions
>             return 200 OK and serve the same content:
>               Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
> ---
>  Continuing my work started at 93431e0607e5.
>  See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@al2klimov.de>' v5.7..master
>  (Actually letting a shell for loop submit all this stuff for me.)
> 
>  If there are any URLs to be removed completely
>  or at least not (just) HTTPSified:
>  Just clearly say so and I'll *undo my change*.
>  See also: https://lkml.org/lkml/2020/6/27/64
> 
>  If there are any valid, but yet not changed URLs:
>  See: https://lkml.org/lkml/2020/6/26/837
> 
>  If you apply the patch, please let me know.
> 
>  Sorry again to all maintainers who complained about subject lines.
>  Now I realized that you want an actually perfect prefixes,
>  not just subsystem ones.
>  I tried my best...
>  And yes, *I could* (at least half-)automate it.
>  Impossible is nothing! :)

The subject prefix is right for sctp, but the patch tag should have
been "PATCH net-next" instead. :-)

Thankfully, they can fix it for us.

Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-20 13:11 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-19 20:26 [PATCH for v5.9] sctp: Replace HTTP links with HTTPS ones Alexander A. Klimov
2020-07-20 13:11 ` Marcelo Ricardo Leitner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).