From: Helmut Grohne <helmut.grohne@intenta.de>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC PATCH] net: dsa: microchip: delete dead code
Date: Thu, 23 Jul 2020 06:24:31 +0200 [thread overview]
Message-ID: <20200723042431.GA14746@laureti-dev> (raw)
In-Reply-To: <20200722143953.GA1339445@lunn.ch>
Hi Andrew,
On Wed, Jul 22, 2020 at 04:39:53PM +0200, Andrew Lunn wrote:
> This patch probably is correct. But it is not obviously correct,
> because there are so many changes at once. Please could you break it
> up.
From my pov, it is less a question of whether it is correct, but whether
it goes into the desired direction. There are a few comments in the
driver that point to pending work. It might as well be that I'm removing
the infrastructure that other patches are meant to build upon.
I guess only the microchip people can answer this and in the event of
silence, the best course of action likely is to proceed. Maybe give it
some time? It's summer holdiday time in northern hemisphere.
> So at minimum, break it up into 3 patches, one per structure. I would
> even go further.
>
> Small patches are easier to review. And if something does break, a git
> bisect gives you more information about what change broke it.
Yes, sure. But this was deliberately RFC and I deliberately merged all
the removals to give you a quick idea of the dead code size. I didn't
expect this to be applied as is but rather generate a reply regarding
the purpose of the code that I propose to remove (in smaller steps).
Helmut
next prev parent reply other threads:[~2020-07-23 4:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 8:33 [RFC PATCH] net: dsa: microchip: delete dead code Helmut Grohne
2020-07-22 14:39 ` Andrew Lunn
2020-07-23 4:24 ` Helmut Grohne [this message]
2020-07-25 17:41 ` Andrew Lunn
2020-08-17 14:55 ` [PATCH v2 0/6] " Helmut Grohne
2020-08-17 14:55 ` [PATCH v2 1/6] net: dsa: microchip: delete unused member ksz_port.phy Helmut Grohne
2020-08-17 14:55 ` [PATCH v2 2/6] net: dsa: microchip: delete unused member ksz_port.sgmii Helmut Grohne
2020-08-17 14:55 ` [PATCH v2 3/6] net: dsa: microchip: delete unused member ksz_port.force Helmut Grohne
2020-08-17 14:55 ` [PATCH v2 4/6] net: dsa: microchip: delete unused member ksz_device.last_port Helmut Grohne
2020-08-17 14:59 ` [PATCH v2 5/6] net: dsa: microchip: delete unused member ksz_device.regs_size Helmut Grohne
2020-08-17 14:59 ` [PATCH v2 6/6] net: dsa: microchip: delete unused member ksz_device.overrides Helmut Grohne
2020-08-17 15:18 ` [PATCH v2 0/6] net: dsa: microchip: delete dead code Florian Fainelli
2020-08-18 7:57 ` Helmut Grohne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723042431.GA14746@laureti-dev \
--to=helmut.grohne@intenta.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).