From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: romieu@fr.zoreil.com, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] via-velocity: Use more typical logging styles
Date: Tue, 04 Aug 2020 12:55:07 -0700 (PDT) [thread overview]
Message-ID: <20200804.125507.1365180086597649192.davem@davemloft.net> (raw)
In-Reply-To: <9f98b7a2c4ce56b9702597eab1349eaa5f1753bb.camel@perches.com>
From: Joe Perches <joe@perches.com>
Date: Mon, 03 Aug 2020 20:23:13 -0700
> Use netdev_<level> in place of VELOCITY_PRT.
> Use pr_<level> in place of printk(KERN_<LEVEL>.
>
> Miscellanea:
>
> o Add pr_fmt to prefix pr_<level> output with "via-velocity: "
> o Remove now unused functions and macros
> o Realign some logging lines
> o Remove devname where pr_<level> is also used
>
> Signed-off-by: Joe Perches <joe@perches.com>
Yeah I definitely like this better, applied, thanks.
prev parent reply other threads:[~2020-08-04 19:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 15:51 [PATCH] via-velocity: Add missing KERN_<LEVEL> where needed Joe Perches
2020-08-03 22:42 ` David Miller
2020-08-04 0:58 ` Joe Perches
2020-08-04 3:23 ` [PATCH V2] via-velocity: Use more typical logging styles Joe Perches
2020-08-04 19:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200804.125507.1365180086597649192.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).