From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>
Cc: romieu@fr.zoreil.com, kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] via-velocity: Add missing KERN_<LEVEL> where needed
Date: Mon, 03 Aug 2020 17:58:52 -0700 [thread overview]
Message-ID: <5f7a5ec560775f3c43fdbb6ac93f858d8b5e37f3.camel@perches.com> (raw)
In-Reply-To: <20200803.154248.2020214547846261577.davem@davemloft.net>
On Mon, 2020-08-03 at 15:42 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Sat, 01 Aug 2020 08:51:03 -0700
>
> > Link status is emitted on multiple lines as it does not use
> > KERN_CONT.
> >
> > Coalesce the multi-part logging into a single line output and
> > add missing KERN_<LEVEL> to a couple logging calls.
> >
> > This also reduces object size.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
>
> The real problem is the whole VELOCITY_PRT() private debug log
> control business this driver is doing.
>
> It should be using the standard netdev logging level infrastructure.
>
> > + VELOCITY_PRT(MSG_LEVEL_INFO, KERN_INFO "set Velocity to forced full mode\n");
>
> You can't tell me that this "KERN_INFO blah blah blah" is really
> something we should add more of these days, right?
>
> If you're going to improve this driver's logging code please do
> so by having it use the standard interfaces.
The existing code is not great and definitely odd.
This is just a bug fix until such time as it's better.
VELOCITY_PRT is not just used for debugging.
The default is output if MSG_LEVEL_INFO and
there's a control for further output.
This is just fixing Linus' change for KERN_CONT
uses on separate lines from awhile ago.
It'd be nice if a via maintainer actually fixed it.
next prev parent reply other threads:[~2020-08-04 0:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-01 15:51 [PATCH] via-velocity: Add missing KERN_<LEVEL> where needed Joe Perches
2020-08-03 22:42 ` David Miller
2020-08-04 0:58 ` Joe Perches [this message]
2020-08-04 3:23 ` [PATCH V2] via-velocity: Use more typical logging styles Joe Perches
2020-08-04 19:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f7a5ec560775f3c43fdbb6ac93f858d8b5e37f3.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).