netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	nikolay@cumulusnetworks.com
Subject: Re: HSR/PRP LRE Stats - What is the right user space interface?
Date: Mon, 10 Aug 2020 13:20:59 -0700	[thread overview]
Message-ID: <20200810132059.4840ac5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <0c743d6e-4a6d-5dcd-88c0-31c6d0971726@ti.com>

On Mon, 10 Aug 2020 15:55:35 -0400 Murali Karicheri wrote:
> Hi Netdev experts,
> 
> IEC-62439 defines following LRE stats:-
> 
> 	"lreTxA",
> 	"lreTxB",
> 	"lreTxC",
> 	"lreErrWrongLanA",
> 	"lreErrWrongLanB",
> 	"lreErrWrongLanC",
> 	"lreRxA",
> 	"lreRxB",
> 	"lreRxC",
> 	"lreErrorsA",
> 	"lreErrorsB",
> 	"lreErrorsC",
> 	"lreNodes",
> 	"lreProxyNodes",
> 	"lreUniqueRxA",
> 	"lreUniqueRxB",
> 	"lreUniqueRxC",
> 	"lreDuplicateRxA",
> 	"lreDuplicateRxB",
> 	"lreDuplicateRxC",
> 	"lreMultiRxA",
> 	"lreMultiRxB",
> 	"lreMultiRxC",
> 	"lreOwnRxA",
> 	"lreOwnRxB",
> 
> These stats are defined also in the IEC-62439 MIB definition. So
> this MIB support is required in Net-SNMP and that requires a proper
> kernel interface to pull the values from the HSR or PRP
> LRE (Link Redundancy Entity). What is the right interface for this?
> Internally TI uses /proc interface for this. But want to check with
> community before sending a patch for this. One choice is ethtool for
> this. Or something else? Would appreciate if someone can clarify so
> that I can work towards a patch for the same.

Are these collected by HW, or also by the bridge code?

Adding a new IFLA_STATS_LINK_* may be the right choice.

      reply	other threads:[~2020-08-10 20:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-10 19:55 HSR/PRP LRE Stats - What is the right user space interface? Murali Karicheri
2020-08-10 20:20 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810132059.4840ac5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).