From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Tom Hebb <tommyhebb@gmail.com>
Cc: "Daniel Díaz" <daniel.diaz@linaro.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Andrii Nakryiko" <andriin@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@chromium.org>,
"Arnaldo Carvalho de Melo" <acme@redhat.com>,
"Jiri Olsa" <jolsa@kernel.org>,
"Stephane Eranian" <eranian@google.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:BPF (Safe dynamic programs and tools)"
<netdev@vger.kernel.org>,
"open list:BPF (Safe dynamic programs and tools)"
<bpf@vger.kernel.org>
Subject: Re: [PATCH] tools build feature: Quote CC and CXX for their arguments
Date: Thu, 13 Aug 2020 10:01:27 -0300 [thread overview]
Message-ID: <20200813130127.GO13995@kernel.org> (raw)
In-Reply-To: <CAMcCCgRGpi+3D4479MLU2xQZJYBA1c6mzZ=bb1VLEwPg3VAgLg@mail.gmail.com>
Em Wed, Aug 12, 2020 at 07:31:32PM -0700, Tom Hebb escreveu:
> On Wed, Aug 12, 2020 at 3:15 PM Daniel Díaz <daniel.diaz@linaro.org> wrote:
> > Makefile.config:414: *** No gnu/libc-version.h found, please install glibc-dev[el]. Stop.
> > Makefile.perf:230: recipe for target 'sub-make' failed
> > make[1]: *** [sub-make] Error 2
> > Makefile:69: recipe for target 'all' failed
> > make: *** [all] Error 2
> >
> > With CC and CXX quoted, some of those features are now detected.
> >
> > Fixes: e3232c2f39ac ("tools build feature: Use CC and CXX from parent")
> >
> > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
>
> Whoops, I'm the one who introduced this issue. Fix looks good, thanks!
>
> Reviewed-by: Thomas Hebb <tommyhebb@gmail.com>
> Fixes: e3232c2f39ac ("tools build feature: Use CC and CXX from parent")
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2020-08-13 13:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 22:15 [PATCH] tools build feature: Quote CC and CXX for their arguments Daniel Díaz
2020-08-13 2:31 ` Tom Hebb
2020-08-13 13:01 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200813130127.GO13995@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel.diaz@linaro.org \
--cc=daniel@iogearbox.net \
--cc=eranian@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=tommyhebb@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).