From: Guenter Roeck <linux@roeck-us.net>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Igor Russkikh <irusskikh@marvell.com>,
netdev@vger.kernel.org,
Mark Starovoytov <mstarovoitov@marvell.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout
Date: Wed, 19 Aug 2020 09:19:53 -0700 [thread overview]
Message-ID: <20200819161953.GA179916@roeck-us.net> (raw)
In-Reply-To: <20200818161439.3dkf6jzp3vuwmvvh@linutronix.de>
On Tue, Aug 18, 2020 at 06:14:39PM +0200, Sebastian Andrzej Siewior wrote:
> Commit
> 8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature")
>
> implemented a read callback with an udelay(10000U). This fails to
> compile on ARM because the delay is >1ms. I doubt that it is needed to
> spin for 10ms even if possible on x86.
>
> >From looking at the code, the context appears to be preemptible so using
> usleep() should work and avoid busy spinning.
>
> Use readx_poll_timeout() in the poll loop.
>
> Cc: Mark Starovoytov <mstarovoitov@marvell.com>
> Cc: Igor Russkikh <irusskikh@marvell.com>
> Signed-off-by: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Fixes: 8dcf2ad39fdb2 ("net: atlantic: add hwmon getter for MAC temperature")
Acked-by: Guenter Roeck <linux@roeck-us.net>
As in: This patch does not cause any additional trouble and will fix the
observed compile failure. However, the submitter of 8dcf2ad39fdb2 might
consider adding a mutex either into hw_atl_b0_get_mac_temp() or into
the calling code.
Thanks,
Guenter
> ---
>
> Could someone with hardware please verify it? It compiles, yes.
>
> drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c
> index 16a944707ba90..8941ac4df9e37 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_b0.c
> @@ -1631,8 +1631,8 @@ static int hw_atl_b0_get_mac_temp(struct aq_hw_s *self, u32 *temp)
> hw_atl_ts_reset_set(self, 0);
> }
>
> - err = readx_poll_timeout_atomic(hw_atl_b0_ts_ready_and_latch_high_get,
> - self, val, val == 1, 10000U, 500000U);
> + err = readx_poll_timeout(hw_atl_b0_ts_ready_and_latch_high_get, self,
> + val, val == 1, 10000U, 500000U);
> if (err)
> return err;
>
> --
> 2.28.0
>
next prev parent reply other threads:[~2020-08-19 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 16:14 [PATCH NET] net: atlantic: Use readx_poll_timeout() for large timeout Sebastian Andrzej Siewior
2020-08-19 16:19 ` Guenter Roeck [this message]
2020-08-20 10:17 ` [EXT] " Igor Russkikh
2020-08-19 23:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819161953.GA179916@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=mstarovoitov@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).