From: "Marek Behún" <marek.behun@nic.cz>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Baruch Siach <baruch@tkos.co.il>, Chris Healy <cphealy@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH RFC russell-king 0/4] Support for RollBall 10G copper SFP modules
Date: Wed, 19 Aug 2020 17:49:50 +0200 [thread overview]
Message-ID: <20200819174950.3a00d71a@dellmb.labs.office.nic.cz> (raw)
In-Reply-To: <20200818163415.GE1551@shell.armlinux.org.uk>
On Tue, 18 Aug 2020 17:34:15 +0100
Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote:
> On Tue, Aug 18, 2020 at 05:47:24PM +0200, Marek Behún wrote:
> > On Tue, 18 Aug 2020 16:36:49 +0100
> > Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote:
> >
> > > On Tue, Aug 18, 2020 at 05:30:55PM +0200, Marek Behún wrote:
> > > > On Tue, 18 Aug 2020 16:08:35 +0100
> > > > Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote:
> > > >
> > > > > > Otherwise it looks nice. I will test this. On what branch
> > > > > > does this apply?
> > > > >
> > > > > My unpublished tip of the universe development. Here's a
> > > > > version on the clearfog branch:
> > > >
> > > > Russell, it seems you do not have commit
> > > >
> > > > e11703330a5d ("net: phy: marvell10g: support XFI rate matching
> > > > mode")
> > > >
> > > > in that branch.
> > >
> > > I don't. That commit is in 5.9-rc1, I'm based on 5.8 at the
> > > moment.
> >
> > I am reworking it so that it applies on top of master together with
> > your other commits from clearfog branch.
>
> If it works for you, I'll rework my branches to adopt this approach.
>
Russell,
if you have time please rebase your work on top of Linus' master or
net-next.
Btw one of your patches in clearfog branch breaks mvneta
(although there are other patches which fix this break).
Check this out:
patch
net: mvneta: move 1ms clock control into mac_prepare/mac_finish
removes definition of variables new_clk and gmac_clk in
mvneta_mac_config, but does not remove one instance of usage, which
can be seen in subsequent patch
net: mvneta: convert to phylink pcs operations
this is fixed by patch
net: mvneta: split out GMAC
where all of this is moved to mvgmac.c file.
I found out because I did not apply the last patch for some reason
(maybe it didn't apply on Linus' master or something, I don't remember),
and it failed to compile.
http://git.arm.linux.org.uk/cgit/linux-arm.git/commit/?h=clearfog&id=ca096c11e6798b1f4da8466ab0c3bf42b6e9fb81
http://git.arm.linux.org.uk/cgit/linux-arm.git/commit/?h=clearfog&id=1e345c538cc73d0b0a63c01a13e69a865905b7ae
http://git.arm.linux.org.uk/cgit/linux-arm.git/commit/?h=clearfog&id=dc33cc833537d06b198c9226d4a230cfc33569a6
I have just sent patches that add 88E6393X switch to mv88e6xxx driver,
since I am testing these SFPs on a Marvell Customer Reference Board
containing this switch.
The board also contains the other PHY supported by the marvell10g PHY
driver, 88E2110, so I will test my changes also on this PHY.
I am waiting for newer documentation for 88E3110, since the one I have
is outdated and does not contain descriptions on how to resolve USXGMII
auto-negotiation, which I would also like to add.
Marek
next prev parent reply other threads:[~2020-08-19 15:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 22:06 [PATCH RFC russell-king 0/4] Support for RollBall 10G copper SFP modules Marek Behún
2020-08-10 22:06 ` [PATCH RFC russell-king 1/4] net: phy: add I2C mdio bus for RollBall compatible SFPs Marek Behún
2020-08-10 22:06 ` [PATCH RFC russell-king 2/4] net: phy: sfp: add support for multigig RollBall modules Marek Behún
2020-08-11 15:15 ` Russell King - ARM Linux admin
2020-08-12 13:33 ` Marek Behún
2020-08-12 14:33 ` Russell King - ARM Linux admin
2020-08-12 14:42 ` Marek Behún
2020-08-10 22:06 ` [PATCH RFC russell-king 3/4] net: phy: marvell10g: change MACTYPE according to phydev->interface Marek Behún
2020-08-11 15:21 ` Russell King - ARM Linux admin
2020-08-12 14:44 ` Marek Behún
2020-08-12 15:00 ` Russell King - ARM Linux admin
2020-08-12 15:37 ` Marek Behún
2020-08-12 15:48 ` Russell King - ARM Linux admin
2020-08-12 15:59 ` Marek Behún
2020-08-12 16:13 ` Marek Behún
2020-08-12 16:22 ` Russell King - ARM Linux admin
2020-08-12 16:28 ` Marek Behún
2020-08-12 16:30 ` Russell King - ARM Linux admin
2020-08-12 16:01 ` Russell King - ARM Linux admin
2020-08-12 16:15 ` Marek Behún
2020-08-12 15:44 ` Andrew Lunn
2020-08-12 15:54 ` Russell King - ARM Linux admin
2020-08-18 17:28 ` Marek Behún
2020-08-10 22:06 ` [PATCH RFC russell-king 4/4] net: phylink: don't fail attaching phy on 1000base-x/2500base-x mode Marek Behún
2020-08-11 15:08 ` [PATCH RFC russell-king 0/4] Support for RollBall 10G copper SFP modules Russell King - ARM Linux admin
2020-08-12 12:31 ` Marek Behún
2020-08-12 12:31 ` Marek Behún
2020-08-12 14:20 ` Marek Behún
2020-08-17 13:49 ` Russell King - ARM Linux admin
2020-08-18 13:43 ` Marek Behún
2020-08-18 15:08 ` Russell King - ARM Linux admin
2020-08-18 15:30 ` Marek Behún
2020-08-18 15:36 ` Russell King - ARM Linux admin
2020-08-18 15:47 ` Marek Behún
2020-08-18 16:34 ` Russell King - ARM Linux admin
2020-08-19 15:49 ` Marek Behún [this message]
2020-08-19 15:54 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819174950.3a00d71a@dellmb.labs.office.nic.cz \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=cphealy@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).