* [PATCH net v2] drivers/net/wan/lapbether: Added needed_tailroom
@ 2020-08-21 21:26 Xie He
2020-08-24 23:09 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Xie He @ 2020-08-21 21:26 UTC (permalink / raw)
To: David S. Miller, Jakub Kicinski, netdev, linux-kernel, linux-x25
Cc: Xie He, Willem de Bruijn, Martin Schiller
The underlying Ethernet device may request necessary tailroom to be
allocated by setting needed_tailroom. This driver should also set
needed_tailroom to request the tailroom needed by the underlying
Ethernet device to be allocated.
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Martin Schiller <ms@dev.tdt.de>
Signed-off-by: Xie He <xie.he.0141@gmail.com>
---
Change from v1:
None
I'm re-sending this patch unchanged because the previous reviewer has
stopped responding for 11 days and he didn't indicate what change I
should do to this patch.
It's hard to find reviewers for this code. I tried to send emails, but
people don't respond. If you can review it, I'd really appreciate it.
I'm not in a hurry so please take your time. Thanks!
---
drivers/net/wan/lapbether.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 1ea15f2123ed..cc297ea9c6ec 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -340,6 +340,7 @@ static int lapbeth_new_device(struct net_device *dev)
*/
ndev->needed_headroom = -1 + 3 + 2 + dev->hard_header_len
+ dev->needed_headroom;
+ ndev->needed_tailroom = dev->needed_tailroom;
lapbeth = netdev_priv(ndev);
lapbeth->axdev = ndev;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] drivers/net/wan/lapbether: Added needed_tailroom
2020-08-21 21:26 [PATCH net v2] drivers/net/wan/lapbether: Added needed_tailroom Xie He
@ 2020-08-24 23:09 ` David Miller
2020-08-24 23:48 ` Xie He
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2020-08-24 23:09 UTC (permalink / raw)
To: xie.he.0141
Cc: kuba, netdev, linux-kernel, linux-x25, willemdebruijn.kernel, ms
From: Xie He <xie.he.0141@gmail.com>
Date: Fri, 21 Aug 2020 14:26:59 -0700
> The underlying Ethernet device may request necessary tailroom to be
> allocated by setting needed_tailroom. This driver should also set
> needed_tailroom to request the tailroom needed by the underlying
> Ethernet device to be allocated.
>
> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Cc: Martin Schiller <ms@dev.tdt.de>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net v2] drivers/net/wan/lapbether: Added needed_tailroom
2020-08-24 23:09 ` David Miller
@ 2020-08-24 23:48 ` Xie He
0 siblings, 0 replies; 3+ messages in thread
From: Xie He @ 2020-08-24 23:48 UTC (permalink / raw)
To: David Miller
Cc: Jakub Kicinski, Linux Kernel Network Developers, LKML, Linux X25,
Willem de Bruijn, Martin Schiller
On Mon, Aug 24, 2020 at 4:09 PM David Miller <davem@davemloft.net> wrote:
>
> Applied, thank you.
Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-24 23:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-21 21:26 [PATCH net v2] drivers/net/wan/lapbether: Added needed_tailroom Xie He
2020-08-24 23:09 ` David Miller
2020-08-24 23:48 ` Xie He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).