From: David Miller <davem@davemloft.net>
To: kalou@tfz.net
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, kuba@kernel.org,
akpm@linux-foundation.org, adobriyan@gmail.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION
Date: Sat, 22 Aug 2020 14:01:41 -0700 (PDT) [thread overview]
Message-ID: <20200822.140141.880909883327091452.davem@davemloft.net> (raw)
In-Reply-To: <CAGbU3_krnjbeKnm6Zyn-tqYCHVZFBkB+oCP-UF_kVOGz=zkKFQ@mail.gmail.com>
From: Pascal Bouchareine <kalou@tfz.net>
Date: Sat, 22 Aug 2020 13:53:03 -0700
> On Sat, Aug 22, 2020 at 1:19 PM Pascal Bouchareine <kalou@tfz.net> wrote:
>>
>> On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine <kalou@tfz.net> wrote:
>>
>> > Would it make sense to also make UDIAG_SHOW_NAME use sk_description?
>> > (And keep the existing change - setsockopt + show_fd_info via
>> > /proc/.../fdinfo/..)
>>
>>
>> Ah,very wrong example - to be more precise, I suppose that'd be adding
>> a couple idiag_ext for sk_description and pid if possible instead
>
> About the pid part -
> On top of multiple pids to scan for a given socket, there's also the
> security provided by /proc - I'm not sure what inet_diag does for that
> So maybe users calling it will need to scan /proc for a long time anyway...
>
> Or is that doable?
I'd like to kindly ask that you do more research into how this kind of
information is advertised to the user using modern interfaces, and what
kinds of permissions and checks are done for those.
You are proposing a new UAPI for the Linux kernel, and with that comes
some level of responsibility.
Thank you.
next prev parent reply other threads:[~2020-08-22 21:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 18:23 [RFC PATCH 0/2] proc,socket: attach description to sockets Pascal Bouchareine
2020-08-15 18:23 ` [PATCH 1/2] mm: add GFP mask param to strndup_user Pascal Bouchareine
2020-08-15 22:42 ` Al Viro
2020-08-16 16:10 ` Alexey Dobriyan
2020-08-15 18:23 ` [PATCH 2/2] net: socket: implement SO_DESCRIPTION Pascal Bouchareine
2020-08-16 5:02 ` kernel test robot
2020-08-16 7:33 ` kernel test robot
2020-08-16 7:33 ` [RFC PATCH] net: socket: sock_set_description() can be static kernel test robot
2020-08-16 9:00 ` [PATCH 2/2] net: socket: implement SO_DESCRIPTION kernel test robot
2020-08-16 18:15 ` Eric Dumazet
2020-08-16 19:30 ` Pascal Bouchareine
2020-08-22 3:28 ` [PATCH v2 1/2] mm: add GFP mask param to strndup_user Pascal Bouchareine
2020-08-22 3:28 ` [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION Pascal Bouchareine
2020-08-22 6:57 ` kernel test robot
2020-08-22 19:36 ` David Miller
2020-08-22 19:59 ` Pascal Bouchareine
2020-08-22 20:19 ` Pascal Bouchareine
2020-08-22 20:53 ` Pascal Bouchareine
2020-08-22 21:01 ` David Miller [this message]
2020-08-23 22:28 ` Pascal Bouchareine
2020-08-22 3:51 ` [PATCH v2 1/2] mm: add GFP mask param to strndup_user Andrew Morton
2020-08-22 19:36 ` Pascal Bouchareine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200822.140141.880909883327091452.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kalou@tfz.net \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).