From: Pascal Bouchareine <kalou@tfz.net>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION
Date: Sun, 23 Aug 2020 15:28:23 -0700 [thread overview]
Message-ID: <CAGbU3_m_2_6iq-ZCMJ0i7E=4nFi6o=akd9_QpeRSa26=U67yog@mail.gmail.com> (raw)
In-Reply-To: <20200822.140141.880909883327091452.davem@davemloft.net>
On Sat, Aug 22, 2020 at 2:01 PM David Miller <davem@davemloft.net> wrote:
> > About the pid part -
> > On top of multiple pids to scan for a given socket, there's also the
> > security provided by /proc - I'm not sure what inet_diag does for that
> > So maybe users calling it will need to scan /proc for a long time anyway...
> >
> > Or is that doable?
>
> I'd like to kindly ask that you do more research into how this kind of
> information is advertised to the user using modern interfaces, and what
> kinds of permissions and checks are done for those.
If we wanted to get rid of having to scan /proc from userland when
using sock_diag to identify associated processes,
I suppose scanning for pids would be the most annoying part?
I understand sock_diag uses CAP_NET_ADMIN for some sensitive bits.
I thought it would require an additional bit of logic to let an
unprivileged user access its own socket "sensitive" data.
Your message makes me think I need to read a lot more about it, so
I'll try that - but more importantly
as you mention APIs and modern interfaces, I think eBPF is going to be
of great help to try and hack
around this data without disturbing existing APIs.
Thanks for taking the time to look into it
next prev parent reply other threads:[~2020-08-23 22:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 18:23 [RFC PATCH 0/2] proc,socket: attach description to sockets Pascal Bouchareine
2020-08-15 18:23 ` [PATCH 1/2] mm: add GFP mask param to strndup_user Pascal Bouchareine
2020-08-15 22:42 ` Al Viro
2020-08-16 16:10 ` Alexey Dobriyan
2020-08-15 18:23 ` [PATCH 2/2] net: socket: implement SO_DESCRIPTION Pascal Bouchareine
2020-08-16 5:02 ` kernel test robot
2020-08-16 7:33 ` kernel test robot
2020-08-16 7:33 ` [RFC PATCH] net: socket: sock_set_description() can be static kernel test robot
2020-08-16 9:00 ` [PATCH 2/2] net: socket: implement SO_DESCRIPTION kernel test robot
2020-08-16 18:15 ` Eric Dumazet
2020-08-16 19:30 ` Pascal Bouchareine
2020-08-22 3:28 ` [PATCH v2 1/2] mm: add GFP mask param to strndup_user Pascal Bouchareine
2020-08-22 3:28 ` [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION Pascal Bouchareine
2020-08-22 6:57 ` kernel test robot
2020-08-22 19:36 ` David Miller
2020-08-22 19:59 ` Pascal Bouchareine
2020-08-22 20:19 ` Pascal Bouchareine
2020-08-22 20:53 ` Pascal Bouchareine
2020-08-22 21:01 ` David Miller
2020-08-23 22:28 ` Pascal Bouchareine [this message]
2020-08-22 3:51 ` [PATCH v2 1/2] mm: add GFP mask param to strndup_user Andrew Morton
2020-08-22 19:36 ` Pascal Bouchareine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGbU3_m_2_6iq-ZCMJ0i7E=4nFi6o=akd9_QpeRSa26=U67yog@mail.gmail.com' \
--to=kalou@tfz.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).