From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, Alice Michael <alice.michael@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jeffrey.t.kirsher@intel.com, Alan Brady <alan.brady@intel.com>,
Phani Burra <phani.r.burra@intel.com>,
Joshua Hay <joshua.a.hay@intel.com>,
Madhu Chittim <madhu.chittim@intel.com>,
Pavan Kumar Linga <pavan.kumar.linga@intel.com>,
Donald Skidmore <donald.c.skidmore@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Sridhar Samudrala <sridhar.samudrala@intel.com>
Subject: Re: [net-next v5 08/15] iecm: Implement vector allocation
Date: Mon, 24 Aug 2020 13:41:36 -0700 [thread overview]
Message-ID: <20200824134136.7ceabe06@kicinski-fedora-PC1C0HJN> (raw)
In-Reply-To: <20200824173306.3178343-9-anthony.l.nguyen@intel.com>
On Mon, 24 Aug 2020 10:32:59 -0700 Tony Nguyen wrote:
> static void iecm_mb_intr_rel_irq(struct iecm_adapter *adapter)
> {
> - /* stub */
> + int irq_num;
> +
> + irq_num = adapter->msix_entries[0].vector;
> + synchronize_irq(irq_num);
I don't think you need to sync irq before freeing it.
> + free_irq(irq_num, adapter);
> static int iecm_mb_intr_init(struct iecm_adapter *adapter)
> {
> - /* stub */
> + int err = 0;
> +
> + iecm_get_mb_vec_id(adapter);
> + adapter->dev_ops.reg_ops.mb_intr_reg_init(adapter);
> + adapter->irq_mb_handler = iecm_mb_intr_clean;
> + err = iecm_mb_intr_req_irq(adapter);
> + return err;
return iecm_mb_intr_req_irq(adapter);
> static void iecm_vport_intr_rel_irq(struct iecm_vport *vport)
> {
> - /* stub */
> + struct iecm_adapter *adapter = vport->adapter;
> + int vector;
> +
> + for (vector = 0; vector < vport->num_q_vectors; vector++) {
> + struct iecm_q_vector *q_vector = &vport->q_vectors[vector];
> + int irq_num, vidx;
> +
> + /* free only the IRQs that were actually requested */
> + if (!q_vector)
> + continue;
> +
> + vidx = vector + vport->q_vector_base;
> + irq_num = adapter->msix_entries[vidx].vector;
> +
> + /* clear the affinity_mask in the IRQ descriptor */
> + irq_set_affinity_hint(irq_num, NULL);
> + synchronize_irq(irq_num);
here as well
> + free_irq(irq_num, q_vector);
> + }
> }
> void iecm_vport_intr_dis_irq_all(struct iecm_vport *vport)
> {
> - /* stub */
> + struct iecm_q_vector *q_vector = vport->q_vectors;
> + struct iecm_hw *hw = &vport->adapter->hw;
> + int q_idx;
> +
> + for (q_idx = 0; q_idx < vport->num_q_vectors; q_idx++)
> + writel_relaxed(0, hw->hw_addr +
> + q_vector[q_idx].intr_reg.dyn_ctl);
Why the use of _releaxed() here? is this performance-sensitive?
There is no barrier after, which makes this code fragile.
> @@ -1052,12 +1122,42 @@ void iecm_vport_intr_dis_irq_all(struct iecm_vport *vport)
> static u32 iecm_vport_intr_buildreg_itr(struct iecm_q_vector *q_vector,
> const int type, u16 itr)
> {
> - /* stub */
> + u32 itr_val;
> +
> + itr &= IECM_ITR_MASK;
> + /* Don't clear PBA because that can cause lost interrupts that
> + * came in while we were cleaning/polling
> + */
> + itr_val = q_vector->intr_reg.dyn_ctl_intena_m |
> + (type << q_vector->intr_reg.dyn_ctl_itridx_s) |
> + (itr << (q_vector->intr_reg.dyn_ctl_intrvl_s - 1));
> +
> + return itr_val;
> }
next prev parent reply other threads:[~2020-08-24 20:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 17:32 [net-next v5 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-08-24 Tony Nguyen
2020-08-24 17:32 ` [net-next v5 01/15] virtchnl: Extend AVF ops Tony Nguyen
2020-08-24 19:42 ` Jakub Kicinski
2020-08-27 17:16 ` Brady, Alan
2020-09-10 21:06 ` Brady, Alan
2020-09-11 15:08 ` Jakub Kicinski
2020-08-24 17:32 ` [net-next v5 02/15] iecm: Add framework set of header files Tony Nguyen
2020-08-24 17:32 ` [net-next v5 03/15] iecm: Add TX/RX " Tony Nguyen
2020-08-24 17:32 ` [net-next v5 04/15] iecm: Common module introduction and function stubs Tony Nguyen
2020-08-24 20:41 ` Jakub Kicinski
2020-08-27 17:18 ` Brady, Alan
2020-08-24 17:32 ` [net-next v5 05/15] iecm: Add basic netdevice functionality Tony Nguyen
2020-08-24 17:32 ` [net-next v5 06/15] iecm: Implement mailbox functionality Tony Nguyen
2020-08-24 20:35 ` Brady, Alan
2020-08-24 20:40 ` Jakub Kicinski
2020-08-24 17:32 ` [net-next v5 07/15] iecm: Implement virtchnl commands Tony Nguyen
2020-08-24 17:32 ` [net-next v5 08/15] iecm: Implement vector allocation Tony Nguyen
2020-08-24 20:41 ` Jakub Kicinski [this message]
2020-08-27 17:28 ` Brady, Alan
2020-08-27 18:19 ` Jakub Kicinski
2020-08-24 17:33 ` [net-next v5 09/15] iecm: Init and allocate vport Tony Nguyen
2020-08-24 17:33 ` [net-next v5 10/15] iecm: Deinit vport Tony Nguyen
2020-08-24 17:33 ` [net-next v5 11/15] iecm: Add splitq TX/RX Tony Nguyen
2020-08-24 20:40 ` Jakub Kicinski
2020-08-27 17:17 ` Brady, Alan
2020-08-24 17:33 ` [net-next v5 12/15] iecm: Add singleq TX/RX Tony Nguyen
2020-08-24 17:33 ` [net-next v5 13/15] iecm: Add ethtool Tony Nguyen
2020-08-24 21:44 ` Michal Kubecek
2020-08-27 17:29 ` Brady, Alan
2020-08-24 17:33 ` [net-next v5 14/15] iecm: Add iecm to the kernel build system Tony Nguyen
2020-08-24 17:33 ` [net-next v5 15/15] idpf: Introduce idpf driver Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824134136.7ceabe06@kicinski-fedora-PC1C0HJN \
--to=kuba@kernel.org \
--cc=alan.brady@intel.com \
--cc=alice.michael@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=phani.r.burra@intel.com \
--cc=sassmann@redhat.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).