From: "Brady, Alan" <alan.brady@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"Michael, Alice" <alice.michael@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"nhorman@redhat.com" <nhorman@redhat.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"Burra, Phani R" <phani.r.burra@intel.com>,
"Hay, Joshua A" <joshua.a.hay@intel.com>,
"Chittim, Madhu" <madhu.chittim@intel.com>,
"Linga, Pavan Kumar" <pavan.kumar.linga@intel.com>,
"Skidmore, Donald C" <donald.c.skidmore@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>
Subject: RE: [net-next v5 04/15] iecm: Common module introduction and function stubs
Date: Thu, 27 Aug 2020 17:18:25 +0000 [thread overview]
Message-ID: <MW3PR11MB4522ADD532ACCF8C7AAF89BD8F550@MW3PR11MB4522.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200824134105.1010fd2f@kicinski-fedora-PC1C0HJN>
> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Monday, August 24, 2020 1:41 PM
> To: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
> Cc: davem@davemloft.net; Michael, Alice <alice.michael@intel.com>;
> netdev@vger.kernel.org; nhorman@redhat.com; sassmann@redhat.com;
> Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>; Brady, Alan
> <alan.brady@intel.com>; Burra, Phani R <phani.r.burra@intel.com>; Hay,
> Joshua A <joshua.a.hay@intel.com>; Chittim, Madhu
> <madhu.chittim@intel.com>; Linga, Pavan Kumar
> <pavan.kumar.linga@intel.com>; Skidmore, Donald C
> <donald.c.skidmore@intel.com>; Brandeburg, Jesse
> <jesse.brandeburg@intel.com>; Samudrala, Sridhar
> <sridhar.samudrala@intel.com>
> Subject: Re: [net-next v5 04/15] iecm: Common module introduction and
> function stubs
>
> On Mon, 24 Aug 2020 10:32:55 -0700 Tony Nguyen wrote:
> > +static inline bool
> > +iecm_tx_singleq_clean_all(struct iecm_q_vector *q_vec, int budget) {
> > + /* stub */
> > +}
>
> Still a lot of static inlines throughout. Are they making any difference? The
> compiler will inline static functions, anyway.
We haven't profiled the inlines to verify they're doing anything, perhaps just some misguided preemptive performance attempt. We can remove them. Will fix.
-alan
next prev parent reply other threads:[~2020-08-27 17:20 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 17:32 [net-next v5 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2020-08-24 Tony Nguyen
2020-08-24 17:32 ` [net-next v5 01/15] virtchnl: Extend AVF ops Tony Nguyen
2020-08-24 19:42 ` Jakub Kicinski
2020-08-27 17:16 ` Brady, Alan
2020-09-10 21:06 ` Brady, Alan
2020-09-11 15:08 ` Jakub Kicinski
2020-08-24 17:32 ` [net-next v5 02/15] iecm: Add framework set of header files Tony Nguyen
2020-08-24 17:32 ` [net-next v5 03/15] iecm: Add TX/RX " Tony Nguyen
2020-08-24 17:32 ` [net-next v5 04/15] iecm: Common module introduction and function stubs Tony Nguyen
2020-08-24 20:41 ` Jakub Kicinski
2020-08-27 17:18 ` Brady, Alan [this message]
2020-08-24 17:32 ` [net-next v5 05/15] iecm: Add basic netdevice functionality Tony Nguyen
2020-08-24 17:32 ` [net-next v5 06/15] iecm: Implement mailbox functionality Tony Nguyen
2020-08-24 20:35 ` Brady, Alan
2020-08-24 20:40 ` Jakub Kicinski
2020-08-24 17:32 ` [net-next v5 07/15] iecm: Implement virtchnl commands Tony Nguyen
2020-08-24 17:32 ` [net-next v5 08/15] iecm: Implement vector allocation Tony Nguyen
2020-08-24 20:41 ` Jakub Kicinski
2020-08-27 17:28 ` Brady, Alan
2020-08-27 18:19 ` Jakub Kicinski
2020-08-24 17:33 ` [net-next v5 09/15] iecm: Init and allocate vport Tony Nguyen
2020-08-24 17:33 ` [net-next v5 10/15] iecm: Deinit vport Tony Nguyen
2020-08-24 17:33 ` [net-next v5 11/15] iecm: Add splitq TX/RX Tony Nguyen
2020-08-24 20:40 ` Jakub Kicinski
2020-08-27 17:17 ` Brady, Alan
2020-08-24 17:33 ` [net-next v5 12/15] iecm: Add singleq TX/RX Tony Nguyen
2020-08-24 17:33 ` [net-next v5 13/15] iecm: Add ethtool Tony Nguyen
2020-08-24 21:44 ` Michal Kubecek
2020-08-27 17:29 ` Brady, Alan
2020-08-24 17:33 ` [net-next v5 14/15] iecm: Add iecm to the kernel build system Tony Nguyen
2020-08-24 17:33 ` [net-next v5 15/15] idpf: Introduce idpf driver Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB4522ADD532ACCF8C7AAF89BD8F550@MW3PR11MB4522.namprd11.prod.outlook.com \
--to=alan.brady@intel.com \
--cc=alice.michael@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=donald.c.skidmore@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=madhu.chittim@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=pavan.kumar.linga@intel.com \
--cc=phani.r.burra@intel.com \
--cc=sassmann@redhat.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).