* [PATCH net-next] net: dsa: mv88e6xxx: Fix W=1 warning with !CONFIG_OF
@ 2020-09-01 2:32 Andrew Lunn
2020-09-01 22:34 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Lunn @ 2020-09-01 2:32 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Andrew Lunn, Andy Shevchenko
When building on platforms without device tree, e.g. amd64, W=1 gives
a warning about mv88e6xxx_mdio_external_match being unused. Replace
of_match_node() with of_device_is_compatible() to prevent this
warning.
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/mv88e6xxx/chip.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c
index ee3b1a6b1ea8..fc3f02168462 100644
--- a/drivers/net/dsa/mv88e6xxx/chip.c
+++ b/drivers/net/dsa/mv88e6xxx/chip.c
@@ -3100,12 +3100,6 @@ static int mv88e6xxx_mdio_register(struct mv88e6xxx_chip *chip,
return 0;
}
-static const struct of_device_id mv88e6xxx_mdio_external_match[] = {
- { .compatible = "marvell,mv88e6xxx-mdio-external",
- .data = (void *)true },
- { },
-};
-
static void mv88e6xxx_mdios_unregister(struct mv88e6xxx_chip *chip)
{
@@ -3125,7 +3119,6 @@ static void mv88e6xxx_mdios_unregister(struct mv88e6xxx_chip *chip)
static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip,
struct device_node *np)
{
- const struct of_device_id *match;
struct device_node *child;
int err;
@@ -3143,8 +3136,8 @@ static int mv88e6xxx_mdios_register(struct mv88e6xxx_chip *chip,
* bus.
*/
for_each_available_child_of_node(np, child) {
- match = of_match_node(mv88e6xxx_mdio_external_match, child);
- if (match) {
+ if (of_device_is_compatible(
+ child, "marvell,mv88e6xxx-mdio-external")) {
err = mv88e6xxx_mdio_register(chip, child, true);
if (err) {
mv88e6xxx_mdios_unregister(chip);
--
2.28.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: dsa: mv88e6xxx: Fix W=1 warning with !CONFIG_OF
2020-09-01 2:32 [PATCH net-next] net: dsa: mv88e6xxx: Fix W=1 warning with !CONFIG_OF Andrew Lunn
@ 2020-09-01 22:34 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-09-01 22:34 UTC (permalink / raw)
To: andrew; +Cc: netdev, andy.shevchenko
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 1 Sep 2020 04:32:57 +0200
> When building on platforms without device tree, e.g. amd64, W=1 gives
> a warning about mv88e6xxx_mdio_external_match being unused. Replace
> of_match_node() with of_device_is_compatible() to prevent this
> warning.
>
> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied, thanks Andrew.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-01 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-01 2:32 [PATCH net-next] net: dsa: mv88e6xxx: Fix W=1 warning with !CONFIG_OF Andrew Lunn
2020-09-01 22:34 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).