* [PATCH] chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4
@ 2020-09-01 14:58 Geert Uytterhoeven
2020-09-03 21:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2020-09-01 14:58 UTC (permalink / raw)
To: Ayush Sawal, Vinay Kumar Yadav, Rohit Maheshwari,
David S . Miller, Jakub Kicinski
Cc: netdev, linux-kernel, Geert Uytterhoeven
While CHELSIO_INLINE_CRYPTO is a guard symbol, and just enabling it does
not cause any additional code to be compiled in, all configuration
options protected by it depend on CONFIG_CHELSIO_T4. Hence it doesn't
make much sense to bother the user with the guard symbol question when
CONFIG_CHELSIO_T4 is disabled.
Fix this by moving the dependency from the individual config options to
the guard symbol.
Fixes: 44fd1c1fd8219551 ("chelsio/chtls: separate chelsio tls driver from crypto driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/ethernet/chelsio/inline_crypto/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/inline_crypto/Kconfig b/drivers/net/ethernet/chelsio/inline_crypto/Kconfig
index a3ef057031e4a50b..be70b59b6f8070e5 100644
--- a/drivers/net/ethernet/chelsio/inline_crypto/Kconfig
+++ b/drivers/net/ethernet/chelsio/inline_crypto/Kconfig
@@ -5,6 +5,7 @@
config CHELSIO_INLINE_CRYPTO
bool "Chelsio Inline Crypto support"
+ depends on CHELSIO_T4
default y
help
Enable support for inline crypto.
@@ -14,7 +15,6 @@ if CHELSIO_INLINE_CRYPTO
config CRYPTO_DEV_CHELSIO_TLS
tristate "Chelsio Crypto Inline TLS Driver"
- depends on CHELSIO_T4
depends on TLS_TOE
help
Support Chelsio Inline TLS with Chelsio crypto accelerator.
@@ -25,7 +25,6 @@ config CRYPTO_DEV_CHELSIO_TLS
config CHELSIO_IPSEC_INLINE
tristate "Chelsio IPSec XFRM Tx crypto offload"
- depends on CHELSIO_T4
depends on XFRM_OFFLOAD
depends on INET_ESP_OFFLOAD || INET6_ESP_OFFLOAD
help
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4
2020-09-01 14:58 [PATCH] chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4 Geert Uytterhoeven
@ 2020-09-03 21:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-09-03 21:55 UTC (permalink / raw)
To: geert+renesas
Cc: ayush.sawal, vinay.yadav, rohitm, kuba, netdev, linux-kernel
From: Geert Uytterhoeven <geert+renesas@glider.be>
Date: Tue, 1 Sep 2020 16:58:41 +0200
> While CHELSIO_INLINE_CRYPTO is a guard symbol, and just enabling it does
> not cause any additional code to be compiled in, all configuration
> options protected by it depend on CONFIG_CHELSIO_T4. Hence it doesn't
> make much sense to bother the user with the guard symbol question when
> CONFIG_CHELSIO_T4 is disabled.
>
> Fix this by moving the dependency from the individual config options to
> the guard symbol.
>
> Fixes: 44fd1c1fd8219551 ("chelsio/chtls: separate chelsio tls driver from crypto driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied to net-next, thank you.
Please clearly state the target tree in your future submissions,
f.e. "Subject: [PATCH net-next] ..."
Thanks again.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-03 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-01 14:58 [PATCH] chelsio/chtls: CHELSIO_INLINE_CRYPTO should depend on CHELSIO_T4 Geert Uytterhoeven
2020-09-03 21:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).