* [PATCH net-next] NFC: digital: Remove two unused macroes
@ 2020-09-04 13:01 Wang Hai
2020-09-05 23:03 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-09-04 13:01 UTC (permalink / raw)
To: davem, kuba, gustavo; +Cc: netdev, linux-kernel
DIGITAL_NFC_DEP_REQ_RES_TAILROOM is never used after it was introduced.
DIGITAL_NFC_DEP_REQ_RES_HEADROOM is no more used after below
commit e8e7f4217564 ("NFC: digital: Remove useless call to skb_reserve()")
Remove them.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
net/nfc/digital_dep.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/net/nfc/digital_dep.c b/net/nfc/digital_dep.c
index 304b1a9bb18a..5971fb6f51cc 100644
--- a/net/nfc/digital_dep.c
+++ b/net/nfc/digital_dep.c
@@ -38,9 +38,6 @@
#define DIGITAL_GB_BIT 0x02
-#define DIGITAL_NFC_DEP_REQ_RES_HEADROOM 2 /* SoD: [SB (NFC-A)] + LEN */
-#define DIGITAL_NFC_DEP_REQ_RES_TAILROOM 2 /* EoD: 2-byte CRC */
-
#define DIGITAL_NFC_DEP_PFB_TYPE(pfb) ((pfb) & 0xE0)
#define DIGITAL_NFC_DEP_PFB_TIMEOUT_BIT 0x10
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] NFC: digital: Remove two unused macroes
2020-09-04 13:01 [PATCH net-next] NFC: digital: Remove two unused macroes Wang Hai
@ 2020-09-05 23:03 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2020-09-05 23:03 UTC (permalink / raw)
To: Wang Hai; +Cc: davem, gustavo, netdev, linux-kernel
On Fri, 4 Sep 2020 21:01:57 +0800 Wang Hai wrote:
> DIGITAL_NFC_DEP_REQ_RES_TAILROOM is never used after it was introduced.
> DIGITAL_NFC_DEP_REQ_RES_HEADROOM is no more used after below
> commit e8e7f4217564 ("NFC: digital: Remove useless call to skb_reserve()")
> Remove them.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-05 23:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-04 13:01 [PATCH net-next] NFC: digital: Remove two unused macroes Wang Hai
2020-09-05 23:03 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).