[PATCH net-next] i40e: remove redundant assigment

[PATCH net-next] i40e: remove redundant assigment

[Marek Majtyka]

Remove a redundant assigment of the software ring pointer in the i40e
driver. The variable is assigned twice with no use in between, so just
get rid of the first occurrence.

Fixes: 3b4f0b66c2b3 ("i40e, xsk: Migrate to new MEM_TYPE_XSK_BUFF_POOL")
Signed-off-by: Marek Majtyka <marekx.majtyka@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
index 2a1153d8957b..8661f461f620 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
@@ -306,7 +306,6 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
 			continue;
 		}
 
-		bi = i40e_rx_bi(rx_ring, rx_ring->next_to_clean);
 		size = (qword & I40E_RXD_QW1_LENGTH_PBUF_MASK) >>
 		       I40E_RXD_QW1_LENGTH_PBUF_SHIFT;
 		if (!size)
-- 
2.20.1

Re: [Intel-wired-lan] [PATCH net-next] i40e: remove redundant assigment

[Björn Töpel]

On Tue, 8 Sep 2020 at 15:53, Marek Majtyka <alardam@gmail.com> wrote:
>
> Remove a redundant assigment of the software ring pointer in the i40e
> driver. The variable is assigned twice with no use in between, so just
> get rid of the first occurrence.
>
> Fixes: 3b4f0b66c2b3 ("i40e, xsk: Migrate to new MEM_TYPE_XSK_BUFF_POOL")
> Signed-off-by: Marek Majtyka <marekx.majtyka@intel.com>

Nice!

Acked-by: Björn Töpel <bjorn.topel@intel.com>

Hmm, this could actually go to the net tree.


Björn

> ---
>  drivers/net/ethernet/intel/i40e/i40e_xsk.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_xsk.c b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> index 2a1153d8957b..8661f461f620 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_xsk.c
> @@ -306,7 +306,6 @@ int i40e_clean_rx_irq_zc(struct i40e_ring *rx_ring, int budget)
>                         continue;
>                 }
>
> -               bi = i40e_rx_bi(rx_ring, rx_ring->next_to_clean);
>                 size = (qword & I40E_RXD_QW1_LENGTH_PBUF_MASK) >>
>                        I40E_RXD_QW1_LENGTH_PBUF_SHIFT;
>                 if (!size)
> --
> 2.20.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan@osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

RE: [Intel-wired-lan] [PATCH net-next] i40e: remove redundant assigment

[Kuruvinakunnel, George]

From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Marek Majtyka
Sent: Tuesday, September 8, 2020 6:05 PM
To: Karlsson, Magnus <magnus.karlsson@intel.com>; Topel, Bjorn <bjorn.topel@intel.com>; intel-wired-lan@lists.osuosl.org; Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org; Fijalkowski, Maciej <maciej.fijalkowski@intel.com>; Majtyka, MarekX <marekx.majtyka@intel.com>; maciejromanfijalkowski@gmain.com
Subject: [Intel-wired-lan] [PATCH net-next] i40e: remove redundant assigment

Remove a redundant assigment of the software ring pointer in the i40e driver. The variable is assigned twice with no use in between, so just get rid of the first occurrence.

Fixes: 3b4f0b66c2b3 ("i40e, xsk: Migrate to new MEM_TYPE_XSK_BUFF_POOL")
Signed-off-by: Marek Majtyka <marekx.majtyka@intel.com>
---
 drivers/net/ethernet/intel/i40e/i40e_xsk.c | 1 -
 1 file changed, 1 deletion(-)

Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@intel.com>